Re: [PATCH v6 8/8] Input: omap4 - pm runtime

Kevin Hilman
2010-12-08T21:11:51Z

"Datta, Shubhrajyoti" <shubhrajyoti@ti.com> writes:

[...]

>> Subject: Re: [PATCH v6 8/8] Input: omap4 - pm runtime
>>
>> Abraham Arce <x0066660@ti.com> writes:
>>
>> > Enable pm runtime in driver
>>
>> So power is enabled on probe and cut on _remove(). Did you consider
>> doing any more fine grained PM for this device? For example, cutting
>> power after some inactivity timer and re-enabling on a
>> keypress/interrupt?

> My idea is that the clock needs to be on to get interrupts (OMAP4 the
> control is at module level and ick/fclk level control is
> difficult). So disabling will prevent interrupts. The keypad is in
> wakeup domain which is always on. So the power impact may be minimal.
>
> What do you think.

I think the changelog needs to be updated to describe the reasons behind
the decisions made.

Kevin