Re: [PATCH 00/10 V5] omap3: pm: introduce support for 3630 OPPs

[Kevin Hilman <khilman@deeprootsystems.com>]

Romit Dasgupta <romit@ti.com> writes:

>>>> [...]
>>>>
>>>>   
>>>>> To facilitate the ongoing discussions on OPP rework, and to have a
>>>>> common base, this series is available as a branch in my linux-omap-pm
>>>>> repo[1].
>>>>>
> <snip>
>> 
>> Yes, I'm in the process cleaning that up.
>> 
>> Once I get some of that cleanup done, I plan to rebase your OPP V5 and
>> include it in the PM branch.
>
> I tried the latest HEAD on pm-wip-opp. Looks like the cpufreq tables are not
> initialized because are not initializing {mpu|dsp|l3}_opps. 

Good catch.  The patch below should fix that.  I've folded it into
my "OMAP3: PM: remove OPP interfaces from OMAP PM layer" patch at the
tip of pm-wip-opp and pushed a new version of that branch.

> Looks like the comment on the latest commit is to use OPP APIs
> directly. Is there any patch currently on that direction?
> Otherwise in the pm-wip-opp branch cpufreq is broken.

Please try this patch on top of your current code, or pull a new
version of pm-wip-opp which should have this included.

Kevin

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 37f0f0d..86d0304 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -1377,6 +1377,10 @@ void __init omap3_pm_init_opp_table(void)
                /* We dont want half configured system at the moment */
                BUG_ON(IS_ERR(omap3_rate_tables[i]));
        }
+
+       mpu_opps = omap3_mpu_rate_table;
+       dsp_opps = omap3_dsp_reate_table;
+       l3_opps = omap3_l3_rate_table;
 }