Re: [PATCH 2/2] OMAP2/3 GPTIMER: skip unnecessary TLDR write during non-autoreload

[Kevin Hilman <khilman@deeprootsystems.com>]

"Woodruff, Richard" <r-woodruff2@ti.com> writes:

>> * Woodruff, Richard <r-woodruff2@ti.com> [081014 12:47]:
>> > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load);
>> > > -     omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
>> > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
>> > >  }
>> >
>> > I seem to recall there was a missed interrupt condition which this worked
>> around.
>> >
>> > IIRC, the original code didn't bother with the load I added back as a work
>> around as a way to get posted mode working.
>>
>> Well these seem to be working based on some quick timer tests.
>> Pushing so we can verify it ;)
>
> This kind of change might be better tested on the PM branch.  It's
> the kind of thing more likely to work with PM disabled.  Testing in
> both is good, PM for many things is less forgiving...

I validated these patches on the PM branch.

I used cyclictest to test lots of timer reprogramming, and also tested
in both RET-while-idle and OFF-while-idle for low frequency timer
reprogramming.

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>