From: Kevin Hilman <khilman@deeprootsystems.com>
To: Mike Chan <mike@android.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com
Subject: Re: [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found.
Date: Wed, 12 Aug 2009 15:53:16 -0700 [thread overview]
Message-ID: <87skfwskyr.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1250100755-29723-1-git-send-email-mike@android.com> (Mike Chan's message of "Wed\, 12 Aug 2009 11\:12\:35 -0700")
Mike Chan <mike@android.com> writes:
> Check pwrdm_name instead of the address of a null struct when at the
> end of pwrdm_dep array.
>
> Reported-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Mike Chan <mike@android.com>
Thanks, to keep it all together, I'll revert the original and merge
this into a single patch.
Kevin
> ---
> arch/arm/mach-omap2/powerdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 0334609..02c1ef6 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -103,7 +103,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm,
>
> }
>
> - if (!pd)
> + if (!pd->pwrdm_name)
> return ERR_PTR(-ENOENT);
>
> return pd->pwrdm;
> --
> 1.5.4.5
next prev parent reply other threads:[~2009-08-12 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 18:12 [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found Mike Chan
2009-08-12 22:53 ` Kevin Hilman [this message]
2009-08-13 6:08 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skfwskyr.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=mike@android.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox