* [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found.
@ 2009-08-12 18:12 Mike Chan
2009-08-12 22:53 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Mike Chan @ 2009-08-12 18:12 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, paul, Mike Chan
Check pwrdm_name instead of the address of a null struct when at the
end of pwrdm_dep array.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mike Chan <mike@android.com>
---
arch/arm/mach-omap2/powerdomain.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index 0334609..02c1ef6 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -103,7 +103,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm,
}
- if (!pd)
+ if (!pd->pwrdm_name)
return ERR_PTR(-ENOENT);
return pd->pwrdm;
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found.
2009-08-12 18:12 [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found Mike Chan
@ 2009-08-12 22:53 ` Kevin Hilman
2009-08-13 6:08 ` Paul Walmsley
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2009-08-12 22:53 UTC (permalink / raw)
To: Mike Chan; +Cc: linux-omap, paul
Mike Chan <mike@android.com> writes:
> Check pwrdm_name instead of the address of a null struct when at the
> end of pwrdm_dep array.
>
> Reported-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Mike Chan <mike@android.com>
Thanks, to keep it all together, I'll revert the original and merge
this into a single patch.
Kevin
> ---
> arch/arm/mach-omap2/powerdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 0334609..02c1ef6 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -103,7 +103,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm,
>
> }
>
> - if (!pd)
> + if (!pd->pwrdm_name)
> return ERR_PTR(-ENOENT);
>
> return pd->pwrdm;
> --
> 1.5.4.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found.
2009-08-12 22:53 ` Kevin Hilman
@ 2009-08-13 6:08 ` Paul Walmsley
0 siblings, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2009-08-13 6:08 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Mike Chan, linux-omap
On Wed, 12 Aug 2009, Kevin Hilman wrote:
> Mike Chan <mike@android.com> writes:
>
> > Check pwrdm_name instead of the address of a null struct when at the
> > end of pwrdm_dep array.
> >
> > Reported-by: Paul Walmsley <paul@pwsan.com>
> > Signed-off-by: Mike Chan <mike@android.com>
>
> Thanks, to keep it all together, I'll revert the original and merge
> this into a single patch.
Great, then:
Acked-by: Paul Walmsley <paul@pwsan.com>
>
> Kevin
>
> > ---
> > arch/arm/mach-omap2/powerdomain.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> > index 0334609..02c1ef6 100644
> > --- a/arch/arm/mach-omap2/powerdomain.c
> > +++ b/arch/arm/mach-omap2/powerdomain.c
> > @@ -103,7 +103,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm,
> >
> > }
> >
> > - if (!pd)
> > + if (!pd->pwrdm_name)
> > return ERR_PTR(-ENOENT);
> >
> > return pd->pwrdm;
> > --
> > 1.5.4.5
>
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-13 6:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-12 18:12 [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found Mike Chan
2009-08-12 22:53 ` Kevin Hilman
2009-08-13 6:08 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox