RE: [PATCH 08/16] OMAP3: Populate scratchpad contents

Woodruff, Richard
2008-10-29T21:35:17Z

> > + arm_context_addr = io_v2p(omap3_arm_context);

> strange is how the code is still working.

Probably just corrupts some DDR a bit higher up.

> I believe what is intented is for arm_context_addr to be a physical
> memory address, right? I've converted this to virt_to_phys().

Yes virt_to_phys() should be here. Current 2.6.24 kernel's do it this way also.

On a related note, I recently added a path to save and restore coresight debug registers. This is allowing pretty good JTAG debugging even with power on (including ETM!). In looking at usage of omap3_arm_context[] I found it needed to be bumped up as it was using 240 elements (with new ETM regs). I need to check with out patch to see if the 128 is enough.

Regards,
Richard W.