From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr' Date: Thu, 14 Mar 2013 10:38:43 -0700 Message-ID: <87txodnaos.fsf@linaro.org> References: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pb0-f52.google.com ([209.85.160.52]:43181 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755902Ab3CNRir (ORCPT ); Thu, 14 Mar 2013 13:38:47 -0400 Received: by mail-pb0-f52.google.com with SMTP id ma3so2552484pbc.39 for ; Thu, 14 Mar 2013 10:38:47 -0700 (PDT) In-Reply-To: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> (Lokesh Vutla's message of "Wed, 13 Mar 2013 12:22:33 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lokesh Vutla Cc: will.deacon@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, santosh.shilimkar@ti.com Lokesh Vutla writes: > Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted > debug} introduces debug powerdown support for self-hosted debug. > While merging the patch 'has_ossr' check was removed which > was needed for hardwares which doesn't support self-hosted debug. > Pandaboard (A9) is one such hardware and Dietmar's orginial > patch did mention this issue. > Without that check on Panda with CPUIDLE enabled, a flood of > below messages thrown. > > [ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch > [ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch > > So restore that check back to avoid the mentioned issue. > > Cc: Dietmar Eggemann > Cc: Will Deacon > Reported-by: Santosh Shilimkar > Acked-by: Santosh Shilimkar > Signed-off-by: Lokesh Vutla I just noticed this on my Panda boards with CPUidle enabled, and $SUBJECT patch fixes it. FWIW, Tested-by: Kevin Hilman I agree that this should get queued for v3.9-rc. Kevin