From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv3 11/11] omap4: use lp params for calculating pmic setup times
Date: Fri, 04 Nov 2011 13:49:31 -0700 [thread overview]
Message-ID: <87ty6j8vfo.fsf@ti.com> (raw)
In-Reply-To: <1317835031-8201-12-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Wed, 5 Oct 2011 20:17:11 +0300")
Tero Kristo <t-kristo@ti.com> writes:
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
Missing descriptive changelog.
Why are the PMIC timings not relevant for OMAP3?
Kevin
> ---
> arch/arm/mach-omap2/vc.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index ee0edf3..badf28b 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -381,6 +381,15 @@ static void omap4_set_timings(struct voltagedomain *voltdm, bool off_mode)
> OMAP4_DOWNTIME_MASK);
>
> __raw_writel(val, OMAP4_SCRM_CLKSETUPTIME);
> +
> + omap_pm_get_pmic_lp_time(&tstart, &tshut);
> +
> + val = omap4_usec_to_val_scrm(tstart, OMAP4_WAKEUPTIME_SHIFT,
> + OMAP4_WAKEUPTIME_MASK);
> + val |= omap4_usec_to_val_scrm(tshut, OMAP4_SLEEPTIME_SHIFT,
> + OMAP4_SLEEPTIME_MASK);
> +
> + __raw_writel(val, OMAP4_SCRM_PMICSETUPTIME);
> }
>
> /* OMAP4 specific voltage init functions */
prev parent reply other threads:[~2011-11-04 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 17:17 [PATCHv3 00/11] voltage domain cleanup Tero Kristo
2011-10-05 17:17 ` [PATCHv3 01/11] OMAP3+: PM: VP: use uV for max and min voltage limits Tero Kristo
2011-10-05 17:17 ` [PATCHv3 02/11] omap: voltage: add definitions for omap_vp_param and omap_vc_param Tero Kristo
2011-10-05 17:17 ` [PATCHv3 03/11] omap3: add vp and vc parameter data Tero Kristo
2011-11-04 20:22 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 04/11] omap4: " Tero Kristo
2011-11-04 20:22 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 05/11] OMAP2+: PM: provide mechanism to describe overall behavior of osc and PMIC Tero Kristo
2011-11-04 21:02 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 06/11] omap3+: vc: use new vc_params and vp_params in parameter calculations Tero Kristo
2011-11-04 21:11 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 07/11] omap3+: vp: use new vp_params for calculating vddmin and vddmax Tero Kristo
2011-11-04 21:13 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 08/11] omap3+: voltage: remove obsolete parameters Tero Kristo
2011-11-04 21:17 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 09/11] omap4: twl: added pmic startup / shutdown times Tero Kristo
2011-11-04 21:21 ` Kevin Hilman
2011-11-04 21:21 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 10/11] omap3+: use lp params for calculating clock setup times Tero Kristo
2011-11-04 21:38 ` Kevin Hilman
2011-11-15 17:22 ` Tero Kristo
2011-11-17 0:10 ` Kevin Hilman
2011-10-05 17:17 ` [PATCHv3 11/11] omap4: use lp params for calculating pmic " Tero Kristo
2011-11-04 20:49 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty6j8vfo.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox