From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v5 3/3] OMAP2+: voltage: add check for missing PMIC info in vp init Date: Fri, 30 Sep 2011 15:14:49 -0700 Message-ID: <87ty7tfzja.fsf@ti.com> References: <1317363153-10259-1-git-send-email-abhilash.kv@ti.com> <1317363153-10259-2-git-send-email-abhilash.kv@ti.com> <1317363153-10259-3-git-send-email-abhilash.kv@ti.com> <1317363153-10259-4-git-send-email-abhilash.kv@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Paul Walmsley's message of "Fri, 30 Sep 2011 12:41:44 -0600 (MDT)") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Walmsley Cc: linux@arm.linux.org.uk, b-cousson@ti.com, tony@atomide.com, linux-kernel@vger.kernel.org, christian.gmeiner@gmail.com, aneesh@ti.com, santosh.shilimkar@ti.com, Abhilash K V , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi Paul, Paul Walmsley writes: > On Fri, 30 Sep 2011, Abhilash K V wrote: > >> From: Abhilash K V >> >> If PMIC info is not available in omap_vp_init(), abort. >> >> Signed-off-by: Abhilash K V >> --- >> arch/arm/mach-omap2/vp.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/vp.c b/arch/arm/mach-omap2/vp.c >> index 66bd700..0ed3d13 100644 >> --- a/arch/arm/mach-omap2/vp.c >> +++ b/arch/arm/mach-omap2/vp.c >> @@ -41,6 +41,13 @@ void __init omap_vp_init(struct voltagedomain *voltdm) >> u32 val, sys_clk_rate, timeout, waittime; >> u32 vddmin, vddmax, vstepmin, vstepmax; >> >> + if (!voltdm->pmic || !voltdm->pmic->uv_to_vsel) { >> + pr_err("%s: PMIC info requried to configure VP for " >> + "vdd_%s not populated.Hence cannot initialize VP\n", >> + __func__, voltdm->name); >> + return; >> + } >> + > > Just wondering about the intent of this patch. Is the goal here to not > call omap_vp_init() for chips that don't have a VP IP block? If so, then > implementing code that does that directly seems like a better approach > than using the PMIC data? Because it seems likely that even SoCs without > VP IP blocks will have PMICs on the board, right? You're right, this isn't really relevant for this series since AM35x doesn't have VP, and hence shouldn't even be calling omap_vp_init(). However, this does fix a bug on devices that do have VP where the VP is initialized before PMIC info has been registered. So, I'll queue this patch as a fix for the voltage layer, but it should not have been included in the AM35x series. Kevin