Re: [RFC 3/3] am35xx: pm: Hook-up with TPS65023

[Kevin Hilman <khilman@ti.com>]

"Menon, Nishanth" <nm@ti.com> writes:

> On Tue, Mar 8, 2011 at 18:48, Premi, Sanjeev <premi@ti.com> wrote:
> [...]
>>> Thinking from a generic soln perspective, lets try and split this into
>>> multiple issues:
>>> a) OPP and Voltage layer voltages - these need to be PMIC aware as well.
>>> See my comment on http://marc.info/?l=linux-omap&m=129955003611548&w=2
>>> -> essentially means that pmic_voltage information should be registered
>>> earlier to opp init
>>>
>>> b) split up structure information for voltage layer - this should be
>>> done in a manner to make PMIC, Board and OMAP SoC information independent.
>>>
>>> c) Ability to plug in multiple PMICs in two manners:
>>>     i) use PMIC with VC/VP/SR combinations.
>>>     ii) use PMIC which is plugged on regulator frameworks.
>>>
>>> If anyone is attempting cleanups, it might be a good idea to base on the
>>> accepted cleanups from pm-core branch which is planned for 39-rc1 to
>>> prevent any surprises ;)
>>
>> [sp] Without trying to understand much internal details on the proposed
>>     solution, workaround is necessary to get AM35x platforms to even boot
>>     on current baselines.
>>
>>     Using regulator framework etc. are long poles; that can easily be
>>     avoided; and this RFC was meant for that.
>>
>>     Knowing that there is already a clean-up effort; simple workaround
>>     makes even better proposition.
> Personally speaking, it is better we do the cleanup and integrate to
> mainline. since we are in the process of cleaning up, it might be a
> good idea for contributions from you and all interested folks to
> ensure that the final code will support the configurations we all need

We have kwown for a long time that we have hard-coded PMIC assumptions
in the current code.  We have slowly added some minimal ways to make
PMIC-variable things pluggable, but indeed it has only ever been tested
with TWL* PMICs.

The best way to fix this going forward is for those who are adding
support for other PMICs to propose solutions that will make this scale
to other PMICs.

If that involves short-term hacks/workarounds to get things
building/booting on non-TWL4030 platforms, that is OK with me.  But I
would also like to be sure that efforts are underway to do it the right
way in parallel.

Kevin



--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html