* [PATCH 4/4] arch/arm/mach-omap2/smartreflex.c: Add missing IS_ERR test [not found] <1295898922-18822-1-git-send-email-julia@diku.dk> @ 2011-01-24 19:55 ` Julia Lawall 2011-01-24 21:24 ` Kevin Hilman 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2011-01-24 19:55 UTC (permalink / raw) To: Tony Lindgren Cc: kernel-janitors, Russell King, linux-omap, linux-arm-kernel, linux-kernel Function _sr_lookup, defined in the same file, returns ERR_PTR not NULL in an error case. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier f; @@ f(...) { ... return ERR_PTR(...); } @@ identifier r.f, fld; expression x; statement S1,S2; @@ x = f(...) ... when != IS_ERR(x) ( if (IS_ERR(x) ||...) S1 else S2 | *x->fld ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- arch/arm/mach-omap2/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 77ecebf..d7deadf 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c @@ -966,7 +966,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev) } sr_info = _sr_lookup(pdata->voltdm); - if (!sr_info) { + if (IS_ERR(sr_info)) { dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", __func__); return -EINVAL; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] arch/arm/mach-omap2/smartreflex.c: Add missing IS_ERR test 2011-01-24 19:55 ` [PATCH 4/4] arch/arm/mach-omap2/smartreflex.c: Add missing IS_ERR test Julia Lawall @ 2011-01-24 21:24 ` Kevin Hilman 0 siblings, 0 replies; 2+ messages in thread From: Kevin Hilman @ 2011-01-24 21:24 UTC (permalink / raw) To: Julia Lawall Cc: Tony Lindgren, kernel-janitors, Russell King, linux-omap, linux-arm-kernel, linux-kernel Julia Lawall <julia@diku.dk> writes: > Function _sr_lookup, defined in the same file, returns ERR_PTR not NULL in > an error case. Thanks, will queue this via the OMAP tree for 2.6.38-rc. Kevin > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > identifier f; > @@ > f(...) { ... return ERR_PTR(...); } > > @@ > identifier r.f, fld; > expression x; > statement S1,S2; > @@ > x = f(...) > ... when != IS_ERR(x) > ( > if (IS_ERR(x) ||...) S1 else S2 > | > *x->fld > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > arch/arm/mach-omap2/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c > index 77ecebf..d7deadf 100644 > --- a/arch/arm/mach-omap2/smartreflex.c > +++ b/arch/arm/mach-omap2/smartreflex.c > @@ -966,7 +966,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev) > } > > sr_info = _sr_lookup(pdata->voltdm); > - if (!sr_info) { > + if (IS_ERR(sr_info)) { > dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", > __func__); > return -EINVAL; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-24 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1295898922-18822-1-git-send-email-julia@diku.dk>
2011-01-24 19:55 ` [PATCH 4/4] arch/arm/mach-omap2/smartreflex.c: Add missing IS_ERR test Julia Lawall
2011-01-24 21:24 ` Kevin Hilman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox