From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
Date: Mon, 29 Nov 2010 16:29:22 +0100 [thread overview]
Message-ID: <87tyj0ywq5.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1290791163-21190-1-git-send-email-segoon@openwall.com> (Vasiliy Kulikov's message of "Fri, 26 Nov 2010 20:06:02 +0300")
Vasiliy Kulikov <segoon@openwall.com> writes:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> Cannot compile this driver, so it is not tested at all.
>
> arch/arm/plat-omap/counter_32k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
> index 155fe43..c1e0d00 100644
> --- a/arch/arm/plat-omap/counter_32k.c
> +++ b/arch/arm/plat-omap/counter_32k.c
> @@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
> return -ENODEV;
>
> sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
> - if (sync_32k_ick)
> + if (!IS_ERR(sync_32k_ick))
> clk_enable(sync_32k_ick);
>
> clocksource_32k.mult = clocksource_hz2mult(32768,
next prev parent reply other threads:[~2010-11-29 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 17:06 [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check Vasiliy Kulikov
2010-11-29 15:29 ` Kevin Hilman [this message]
2010-12-06 23:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyj0ywq5.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=segoon@openwall.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox