From: Kevin Hilman <khilman@deeprootsystems.com>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4
Date: Thu, 21 Oct 2010 13:20:20 -0700 [thread overview]
Message-ID: <87tykfs3gb.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101021190833.GW3958@legolas.emea.dhcp.ti.com> (Felipe Balbi's message of "Thu, 21 Oct 2010 22:08:33 +0300")
Felipe Balbi <balbi@ti.com> writes:
> On Thu, Oct 21, 2010 at 12:57:41PM -0500, Kevin Hilman wrote:
>>Felipe Balbi <balbi@ti.com> writes:
>>
>>> Add 32k timer hwmod to the database.
>>>
>>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>>
>>Not sure how this is working correctly on OMAP2 and OMAP3. All the
>>hwmods are mising the oh->prcm.omap2.module_offs field.
>>
>>Without this, _wait_target_ready *should* fail, and the hwmod should not
>>actually be enabled.
>>
>>Since this was tested to work, I guess what's happening, is because
>>module_offs == 0 (OCP_MOD), it's reading from the IDLEST register offset
>>in OCP_MOD, which is an undefined register. On 34xx, we get lucky that
>>that bit is zero so omap2_cm_wait_module_ready succeeds. On 24xx, the
>>polarity of the idlest bits is inversed, so this would likely fail on
>>OMAP2.
>>
>>Either way, the right fix for this is to ensure that OMAP2/3 hwmods have
>>.module_offs populated correctly.
>
> I'll look again but when I was reading omap3 TRM I couldn't find IDLEST
> for this module, maybe I missed something.
It's there, see bit 2 of CM_IDLEST_WKUP.
Kevin
next prev parent reply other threads:[~2010-10-21 20:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 9:22 [PATCH 0/5] 32k sync timer meets hwmod Felipe Balbi
2010-10-19 9:22 ` [PATCH 1/5] arm: omap1/2/3/4: convert 32k-sync driver to a platform_driver Felipe Balbi
2010-10-19 9:22 ` [PATCH 2/5] arm: omap: counter-32k: convert to pm_runtime API Felipe Balbi
2010-10-21 17:46 ` Kevin Hilman
2010-10-21 19:06 ` Felipe Balbi
2010-10-21 20:17 ` Kevin Hilman
2010-10-22 6:31 ` Felipe Balbi
2010-10-19 9:22 ` [PATCH 3/5] clocksource: move omap 32k timer to drivers/clocksource Felipe Balbi
2010-10-19 9:22 ` [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4 Felipe Balbi
2010-10-20 21:32 ` Cousson, Benoit
2010-10-21 5:30 ` Felipe Balbi
2010-10-21 17:57 ` Kevin Hilman
2010-10-21 19:08 ` Felipe Balbi
2010-10-21 20:20 ` Kevin Hilman [this message]
2010-10-21 20:29 ` Kevin Hilman
2010-10-19 9:22 ` [PATCH 5/5] arm: omap: 32k: move to omap_device_build Felipe Balbi
2010-10-19 9:23 ` [PATCH 0/5] 32k sync timer meets hwmod Felipe Balbi
2010-10-20 21:29 ` Cousson, Benoit
2010-10-21 5:04 ` DebBarma, Tarun Kanti
2010-10-21 18:00 ` Kevin Hilman
2010-10-21 19:09 ` Felipe Balbi
2010-10-22 19:01 ` green
2010-10-25 7:45 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tykfs3gb.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).