RE: [PATCH v2 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430

Nayak, Rajendra
2010-09-21T07:26:12Z

> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Tuesday, September 21, 2010 12:47 PM
> To: Nayak, Rajendra
> Cc: linux-omap@vger.kernel.org; Kevin Hilman
> Subject: Re: [PATCH v2 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430
>
> On Fri, 17 Sep 2010, Rajendra Nayak wrote:
>
> > Add hwmod structures for I2C controllers on OMAP3430.
>
> Also in this patch:
>
> > +static struct omap_hwmod omap3xxx_i2c1_hwmod = {
> > + .name = "i2c1",
> > + .mpu_irqs = i2c1_mpu_irqs,
> > + .mpu_irqs_cnt = ARRAY_SIZE(i2c1_mpu_irqs),
> > + .sdma_reqs = i2c1_sdma_reqs,
> > + .sdma_reqs_cnt = ARRAY_SIZE(i2c1_sdma_reqs),
> > + .main_clk = "i2c1_fck",
> > + .prcm = {
> > + .omap2 = {
> > + .prcm_reg_id = 1,
> > + .module_bit = OMAP3430_GRPSEL_I2C1_SHIFT,
> > + .idlest_reg_id = 1,
> > + .idlest_idle_bit = OMAP3430_GRPSEL_I2C1_SHIFT,
>
> This should be OMAP3430_ST_I2C1_SHIFT; likewise for the rest of the I2C
> hwmods.

Thanks. Will fix this too.

>
> > + },
> > + },
> > + .slaves = omap3xxx_i2c1_slaves,
> > + .slaves_cnt = ARRAY_SIZE(omap3xxx_i2c1_slaves),
> > + .class = &i2c_class,
> > + .dev_attr = &i2c1_dev_attr,
> > + .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> > +};
>
>
> - Paul