Re: [pm-wip/uart][PATCH 3/5 v2] OMAP3: serial: Fix uart4 handling for 3630

[Kevin Hilman <khilman@deeprootsystems.com>]

"Govindraj.R" <govindraj.raja@ti.com> writes:

> This patch makes the following:
>  - Adds missing wakeup padding register handling.
>  - Fixes a hardcode to use PER module ONLY on UART3.
>  - Muxmode usage needed for uart4 for 3630, for padconf
>    wakeup on uart4_rx line. uart4_rx signal is available
>    under mode-2 in gpmc_wait3. Thus have to ensure we are
>    in right mux mode before accesing any padconf register.
>    So ensure right mux mode for uarti padconf access.

I think this mux-mode handling should be done as a separate patch with
more description as exactly what problem this is solving.

Presumably, whatever problem you're solving not unique to 3630 UART4
as the UARTs on the other platforms can be muxed with other
peripherals as well.

Based on the way it's being mux'd (and continually re-mux'd) in this
patch, it looks like the mux settings for that pin are being
dynamically changed elsewhere in the code.  If that's the case, then
that should be better understood, and this code should likely re-mux
to the original settings when its done.

Kevin