Re: [PATCH v5] OMAP UART: Add omap-serial driver support.

Kevin Hilman
2010-01-27T19:11:02Z

Tony Lindgren <tony@atomide.com> writes:

> * Kevin Hilman <khilman@deeprootsystems.com> [100127 10:05]:
>> Tony Lindgren <tony@atomide.com> writes:
>>
>> > * Kevin Hilman <khilman@deeprootsystems.com> [100127 09:46]:
>> >> Tony Lindgren <tony@atomide.com> writes:
>> >>
>> >> [...]
>> >>
>> >> >
>> >> > Do you have the board related patches somewhere so people can
>> >> > actually test this driver?
>> >> >
>> >>
>> >> Tony, the board/platform related patches are in my pm-wip/uart branch
>> >> as part of the conversion of that code to hwmod/omap_device.
>> >>
>> >> This patch on top of that branch is working fine, at least for
>> >> basic console.
>> >
>> > OK. What's the dependency to the PM branch with these UART
>> > patches?
>>
>> The driver itself has no dependencies.
>>
>> But the platform changes and conversion to hwmod/omap_device have all
>> been done on top of the PM branch + various ongoing hwmod/omap_device
>> patches.
>
> Sounds like we should do all the hwmod conversion patches against the
> mainline nowadays to cut down the dependencies. If there are some
> dependencies still to PM branch, those should be patched away ASAP.

Agreed, and already done. I'm collecting the various hwmod,
omap_device conversion patches floating around and have them in a
branch of my PM tree based on mainline.

However, so far I have only been testing them when combined with the
rest of the PM branch.

> Adding new device drivers should not have any dependencies except
> the mainline kernel :)

In general that's true. But for all new drivers, I think we need to
require that they use hwmod + omap_device so we don't have to do that
part twice. Since the hwmod + omap_device stuff has a little ways to
go, there will be some out-of-tree dependencies.

Kevin