Re: [PATCH 1/3] OMAP: omap_device: optionally auto-adjust device activate/deactivate latencies

[Kevin Hilman <khilman@deeprootsystems.com>]

Nishanth Menon <nm@ti.com> writes:

[...]

>>> nitpick: I think you need {} for the else part too now a days..
>>
>> you mean as a CodingStyle issue, or a compiler issue?
>> do you have a reference for this requirement? 
>>
>> do you mean if the 'if' part has {}, the else part should too, even if
>> it's a single line?
>>
>> I don't really care one way or the other, just want to know more about
>> what you're suggesting.
> Apologies on the obscure comment. I meant Coding style.
> Documentation/CodingStyle says:
>
>  171 This does not apply if one branch of a conditional statement is a
> single
>  172 statement. Use braces in both branches.
>  173
>  174 if (condition) {
>  175         do_this();
>  176         do_that();
>  177 } else {
>  178         otherwise();
>  179 }

doh, looks like I should've RTFM.

Thanks for the pointer.

Kevin