From: Kalle Valo <kalle.valo@iki.fi>
To: Luke-Jr <luke@dashjr.org>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>
Subject: Re: [PATCH] OMAP2: add USB platform data and initialization for Nokia N800 and N810
Date: Wed, 30 Dec 2009 09:14:34 +0200 [thread overview]
Message-ID: <87tyv9vspx.fsf@purkki.valot.fi> (raw)
In-Reply-To: <200912291505.51230.luke@dashjr.org> (Luke-Jr's message of "Tue\, 29 Dec 2009 15\:05\:46 -0600")
(dropping lkml)
"Luke-Jr" <luke@dashjr.org> writes:
> I think 4 or 5 files with ~350 lines is more manageable than a
> single 1700- line board file, especially when considering that parts
> depend on multiple configuration options (LCD, which turns out to be
> a 128-line file, depends on 3 config options: N8x0, Blizzard, and
> MIPID).
I tend to disagree. Scattering code to small files doesn't benefit
that much, just makes it harder to find code. IMHO a 2k line file is
perfectly acceptable and usable.
But if you really want smaller files, I'm not going to object. You're
the one doing the all work here :)
--
Kalle Valo
next prev parent reply other threads:[~2009-12-30 7:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 7:52 [PATCH] OMAP2: add USB platform data and initialization for Nokia N800 and N810 Luke-Jr
2009-12-29 8:29 ` Kalle Valo
2009-12-29 8:46 ` Luke-Jr
2009-12-29 8:55 ` Kalle Valo
2009-12-29 12:51 ` Felipe Balbi
2009-12-29 21:05 ` Luke-Jr
2009-12-30 3:10 ` Luke-Jr
2009-12-30 7:17 ` Kalle Valo
2009-12-30 9:02 ` Luke-Jr
2009-12-30 12:04 ` Felipe Balbi
2009-12-30 7:14 ` Kalle Valo [this message]
2009-12-29 19:24 ` Tony Lindgren
2009-12-29 19:35 ` Felipe Balbi
2009-12-29 19:42 ` Tony Lindgren
2009-12-29 19:49 ` Felipe Balbi
2009-12-29 19:53 ` Tony Lindgren
2009-12-29 19:57 ` Felipe Balbi
2009-12-29 20:28 ` Luke-Jr
2009-12-29 20:35 ` Felipe Balbi
2010-01-05 23:24 ` problem with n810 boot up Francisco Alecrim
2010-01-05 23:46 ` Luke-Jr
2010-01-06 2:46 ` Francisco Alecrim
2010-01-06 3:07 ` Luke-Jr
2010-01-06 22:11 ` Francisco Alecrim
2010-01-06 22:45 ` Felipe Balbi
2010-01-06 23:02 ` Francisco Alecrim
2010-01-06 23:40 ` Luke-Jr
2010-01-06 23:59 ` Francisco Alecrim
2010-01-07 0:10 ` Luke-Jr
2010-01-07 15:25 ` Francisco Alecrim
2010-01-07 15:40 ` Luke-Jr
2010-01-07 16:55 ` green
2010-01-09 2:56 ` Luke-Jr
2010-01-09 4:59 ` green
2010-01-07 0:33 ` Siarhei Siamashka
2010-01-07 2:04 ` Francisco Alecrim
2010-01-09 5:03 ` green
2010-01-09 17:43 ` Luke-Jr
2010-01-09 23:53 ` green
[not found] ` <4B489CC5.5080700@gmail.com>
2010-01-09 23:35 ` green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyv9vspx.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=luke@dashjr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox