Re: [PATCH 00/10 V5] omap3: pm: introduce support for 3630 OPPs

[Kevin Hilman <khilman@deeprootsystems.com>]

"Menon, Nishanth" <nm@ti.com> writes:

> Kevin Hilman said the following on 12/17/2009 04:07 AM:
>> Kevin Hilman <khilman@deeprootsystems.com> writes:
>>
>>   
>>> Nishanth Menon <nm@ti.com> writes:
>>>
>>>     
>>>> Hi,
>>>> Thanks for all the comments. Here are the *changed* patches since V5
>>>>
>>>> What changed in V5:
>>>> * review comment incorporated
>>>> * vsel is deprecated now
>>>> * I seem to have hit a checkpatch.pl bug as in
>>>> http://lkml.org/lkml/2009/12/11/573, made me check the usage
>>>>   of __deprecated for struct params, and used it in a
>>>>   consistent manner to functions..
>>>> * More warnings added to build :( (deprecated ones ofcourse)
>>>> * removed OMAP_OPP_DEF_TERMINATOR
>>>> * 3430 and 3630 patches changed as a result
>>>>       
>> [...]
>>
>>   
>>> To facilitate the ongoing discussions on OPP rework, and to have a
>>> common base, this series is available as a branch in my linux-omap-pm
>>> repo[1].
>>>
>>> The branch is called 'pm-wip-opp' and I have rebased onto the PM
>>> branch I pushed today.
>>>     
>>
>>   
> Thanks Kevin.
>
>> I forgot to mention that I've also pushed the patch for removing OPP
>> interface from the OMAP PM layer[1] to the work-in-progress OPP
>> branch.
>>
>> Kevin
>>
>> [1] http://marc.info/?l=linux-omap&m=125917007423545&w=2
>>   
> Reg [1]
> What is the point of having
> void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
> struct omap_sdrc_params *sdrc_cs1,
> struct omap_opp *mpu_opps,
> struct omap_opp *dsp_opps,
> struct omap_opp *l3_opps)
>
> Why have mpu_opps, dsp_opps and l3_opps anymore? those parameters are
> unused anymore. the patch should have changed omap2_init_common_hw and
> related board calls - am I right?

Yes, I'm in the process cleaning that up.

Once I get some of that cleanup done, I plan to rebase your OPP V5 and
include it in the PM branch.

Kevin