From: Kevin Hilman <khilman@ti.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: mach-omap2: voltage: debugfs: fix memory leak
Date: Fri, 28 Jan 2011 14:15:25 -0800 [thread overview]
Message-ID: <87vd18ad4y.fsf@ti.com> (raw)
In-Reply-To: <1296231851-20632-1-git-send-email-aaro.koskinen@nokia.com> (Aaro Koskinen's message of "Fri, 28 Jan 2011 18:24:11 +0200")
Aaro Koskinen <aaro.koskinen@nokia.com> writes:
> The temporary string holding the directory name to be created should
> be released.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Thanks, queuing in pm-fixes for 2.6.38.
Kevin
> ---
> arch/arm/mach-omap2/voltage.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> index ed6079c..12be525 100644
> --- a/arch/arm/mach-omap2/voltage.c
> +++ b/arch/arm/mach-omap2/voltage.c
> @@ -471,6 +471,7 @@ static void __init vdd_debugfs_init(struct omap_vdd_info *vdd)
> strcat(name, vdd->voltdm.name);
>
> vdd->debug_dir = debugfs_create_dir(name, voltage_dir);
> + kfree(name);
> if (IS_ERR(vdd->debug_dir)) {
> pr_warning("%s: Unable to create debugfs directory for"
> " vdd_%s\n", __func__, vdd->voltdm.name);
prev parent reply other threads:[~2011-01-28 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 16:24 [PATCH] arm: mach-omap2: voltage: debugfs: fix memory leak Aaro Koskinen
2011-01-28 22:15 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd18ad4y.fsf@ti.com \
--to=khilman@ti.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox