Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: 4430sdp board support for the the GPIO keys
Date: Tue, 31 Aug 2010 09:02:03 -0700	[thread overview]
Message-ID: <87vd6qsrd0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1283269578-3962-1-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Tue, 31 Aug 2010 21:16:18 +0530")

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> omap 4430sdp board support for the GPIO keys.
> The proximity sensor is connected to GPIO and is registered as a
> GPIO key.
> - Making the default state of the sensor off at bootup
> - The init is called before platform_add_devices
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

I still think the subject is wrong:  You're adding support for the
proximity sensor *using* GPIO keys, not adding support for GPIO keys:

    OMAP: 4430SDP: add proximity sensor via GPIO keys

or something like that.

Kevin


  reply	other threads:[~2010-08-31 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 15:46 [PATCH] omap: 4430sdp board support for the the GPIO keys Shubhrajyoti D
2010-08-31 16:02 ` Kevin Hilman [this message]
2010-09-01  6:19   ` Datta, Shubhrajyoti
  -- strict thread matches above, loose matches on Subject: below --
2010-08-20  8:17 Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vd6qsrd0.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox