* [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
@ 2009-08-24 6:28 Reddy, Teerth
2009-08-27 8:25 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Reddy, Teerth @ 2009-08-24 6:28 UTC (permalink / raw)
To: linux-omap@vger.kernel.org, khilman@deeprootsystems.com
>From : Teerth Reddy <teerth@ti.com>
This patch changes for setting the padconf value for sys_nirq line which is connected to T2 INTR1.
This will fix the T2 keypad wakeup issue on OMAP3 SDP.
Signed-off-by: Teerth Reddy < teerth@ti.com >
---
arch/arm/mach-omap2/board-3430sdp.c | 6 ++++++
arch/arm/mach-omap2/mux.c | 5 +++++
arch/arm/plat-omap/include/mach/mux.h | 3 +++
3 files changed, 14 insertions(+)
Index: linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-omap2/board-3430sdp.c
+++ linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
@@ -574,6 +574,11 @@ static inline void board_smc91x_init(voi
#endif
+static void enable_board_wakeup_source(void)
+{
+ omap_cfg_reg(AF26_34XX_SYS_NIRQ);
+}
+
static void __init omap_3430sdp_init(void)
{
omap3430_i2c_init();
@@ -590,6 +595,7 @@ static void __init omap_3430sdp_init(voi
usb_musb_init();
board_smc91x_init();
usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, true, true, 57, 61);
+ enable_board_wakeup_source();
}
static void __init omap_3430sdp_map_io(void)
Index: linux-omap-pm/arch/arm/mach-omap2/mux.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-omap2/mux.c
+++ linux-omap-pm/arch/arm/mach-omap2/mux.c
@@ -492,6 +492,11 @@ MUX_CFG_34XX("H16_34XX_SDRC_CKE0", 0x262
OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
MUX_CFG_34XX("H17_34XX_SDRC_CKE1", 0x264,
OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
+
+/* SYS_NIRQ T2 INT1 */
+MUX_CFG_34XX("AF26_34XX_SYS_NIRQ", 0x1E0,
+ OMAP3_WAKEUP_EN | OMAP34XX_PIN_INPUT_PULLUP |
+ OMAP34XX_MUX_MODE0)
};
#define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
Index: linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
===================================================================
--- linux-omap-pm.orig/arch/arm/plat-omap/include/mach/mux.h
+++ linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
@@ -857,6 +857,9 @@ enum omap34xx_index {
/* OMAP3 SDRC CKE signals to SDR/DDR ram chips */
H16_34XX_SDRC_CKE0,
H17_34XX_SDRC_CKE1,
+
+ /* SYS_NIRQ T2 INT1 */
+ AF26_34XX_SYS_NIRQ,
};
struct omap_mux_cfg {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
2009-08-24 6:28 [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3 Reddy, Teerth
@ 2009-08-27 8:25 ` Kevin Hilman
2009-11-03 16:32 ` Premi, Sanjeev
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2009-08-27 8:25 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org
Hi Teerth,
"Reddy, Teerth" <teerth@ti.com> writes:
> From : Teerth Reddy <teerth@ti.com>
>
> This patch changes for setting the padconf value for sys_nirq line
> which is connected to T2 INTR1. This will fix the T2 keypad wakeup
> issue on OMAP3 SDP.
>
> Signed-off-by: Teerth Reddy < teerth@ti.com >
Patch looks good, thanks. I'll pull this into PM branch and queue
in my PM fixes queue for next merge window.
I did a minor update by adding a comment in the
enable_board_wakeup_source function stating that this is the
interrupt pin used for T2.
Kevin
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 6 ++++++
> arch/arm/mach-omap2/mux.c | 5 +++++
> arch/arm/plat-omap/include/mach/mux.h | 3 +++
> 3 files changed, 14 insertions(+)
>
> Index: linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/board-3430sdp.c
> +++ linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
> @@ -574,6 +574,11 @@ static inline void board_smc91x_init(voi
>
> #endif
>
> +static void enable_board_wakeup_source(void)
> +{
> + omap_cfg_reg(AF26_34XX_SYS_NIRQ);
> +}
> +
> static void __init omap_3430sdp_init(void)
> {
> omap3430_i2c_init();
> @@ -590,6 +595,7 @@ static void __init omap_3430sdp_init(voi
> usb_musb_init();
> board_smc91x_init();
> usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, true, true, 57, 61);
> + enable_board_wakeup_source();
> }
>
> static void __init omap_3430sdp_map_io(void)
> Index: linux-omap-pm/arch/arm/mach-omap2/mux.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/mux.c
> +++ linux-omap-pm/arch/arm/mach-omap2/mux.c
> @@ -492,6 +492,11 @@ MUX_CFG_34XX("H16_34XX_SDRC_CKE0", 0x262
> OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
> MUX_CFG_34XX("H17_34XX_SDRC_CKE1", 0x264,
> OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
> +
> +/* SYS_NIRQ T2 INT1 */
> +MUX_CFG_34XX("AF26_34XX_SYS_NIRQ", 0x1E0,
> + OMAP3_WAKEUP_EN | OMAP34XX_PIN_INPUT_PULLUP |
> + OMAP34XX_MUX_MODE0)
> };
>
> #define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
> Index: linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/plat-omap/include/mach/mux.h
> +++ linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
> @@ -857,6 +857,9 @@ enum omap34xx_index {
> /* OMAP3 SDRC CKE signals to SDR/DDR ram chips */
> H16_34XX_SDRC_CKE0,
> H17_34XX_SDRC_CKE1,
> +
> + /* SYS_NIRQ T2 INT1 */
> + AF26_34XX_SYS_NIRQ,
> };
>
> struct omap_mux_cfg {
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
2009-08-27 8:25 ` Kevin Hilman
@ 2009-11-03 16:32 ` Premi, Sanjeev
2009-11-03 22:04 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Premi, Sanjeev @ 2009-11-03 16:32 UTC (permalink / raw)
To: Kevin Hilman, Reddy, Teerth; +Cc: linux-omap@vger.kernel.org
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Kevin Hilman
> Sent: Thursday, August 27, 2009 1:55 PM
> To: Reddy, Teerth
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
>
> Hi Teerth,
>
> "Reddy, Teerth" <teerth@ti.com> writes:
>
> > From : Teerth Reddy <teerth@ti.com>
> >
> > This patch changes for setting the padconf value for sys_nirq line
> > which is connected to T2 INTR1. This will fix the T2 keypad wakeup
> > issue on OMAP3 SDP.
> >
> > Signed-off-by: Teerth Reddy < teerth@ti.com >
>
> Patch looks good, thanks. I'll pull this into PM branch and queue
> in my PM fixes queue for next merge window.
>
> I did a minor update by adding a comment in the
> enable_board_wakeup_source function stating that this is the
> interrupt pin used for T2.
>
> Kevin
>
Teerth, Kevin,
Did you test it with OFF mode enabled?
When I do "echo 1 > /sys/power/enable_off_mode" I don't see resume on the omap3evm.
Schematics for the keypad are/seem to be same for EVM and SDP.
Best regards,
Sanjeev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
2009-11-03 16:32 ` Premi, Sanjeev
@ 2009-11-03 22:04 ` Kevin Hilman
2009-11-04 14:01 ` Premi, Sanjeev
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2009-11-03 22:04 UTC (permalink / raw)
To: Premi, Sanjeev; +Cc: Reddy, Teerth, linux-omap@vger.kernel.org
"Premi, Sanjeev" <premi@ti.com> writes:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org
>> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Kevin Hilman
>> Sent: Thursday, August 27, 2009 1:55 PM
>> To: Reddy, Teerth
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
>>
>> Hi Teerth,
>>
>> "Reddy, Teerth" <teerth@ti.com> writes:
>>
>> > From : Teerth Reddy <teerth@ti.com>
>> >
>> > This patch changes for setting the padconf value for sys_nirq line
>> > which is connected to T2 INTR1. This will fix the T2 keypad wakeup
>> > issue on OMAP3 SDP.
>> >
>> > Signed-off-by: Teerth Reddy < teerth@ti.com >
>>
>> Patch looks good, thanks. I'll pull this into PM branch and queue
>> in my PM fixes queue for next merge window.
>>
>> I did a minor update by adding a comment in the
>> enable_board_wakeup_source function stating that this is the
>> interrupt pin used for T2.
>>
>> Kevin
>>
>
> Teerth, Kevin,
>
> Did you test it with OFF mode enabled?
I tested on SDP, but not on omap3evm since that was the only board
file touched by this patch.
> When I do "echo 1 > /sys/power/enable_off_mode" I don't see resume on the omap3evm.
>
> Schematics for the keypad are/seem to be same for EVM and SDP.
I'm guessing that it's because the patch from Teerth only muxes this
pin for the SDP. I'm guessing that doing the same omap_cfg_reg in the
OMAP3EVM board file will get this working.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
2009-11-03 22:04 ` Kevin Hilman
@ 2009-11-04 14:01 ` Premi, Sanjeev
2009-11-06 14:12 ` Premi, Sanjeev
0 siblings, 1 reply; 6+ messages in thread
From: Premi, Sanjeev @ 2009-11-04 14:01 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Reddy, Teerth, linux-omap@vger.kernel.org
> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Wednesday, November 04, 2009 3:35 AM
> To: Premi, Sanjeev
> Cc: Reddy, Teerth; linux-omap@vger.kernel.org
> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
>
> "Premi, Sanjeev" <premi@ti.com> writes:
>
> >> -----Original Message-----
> >> From: linux-omap-owner@vger.kernel.org
> >> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Kevin Hilman
> >> Sent: Thursday, August 27, 2009 1:55 PM
> >> To: Reddy, Teerth
> >> Cc: linux-omap@vger.kernel.org
> >> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
> >>
> >> Hi Teerth,
> >>
> >> "Reddy, Teerth" <teerth@ti.com> writes:
> >>
> >> > From : Teerth Reddy <teerth@ti.com>
> >> >
> >> > This patch changes for setting the padconf value for
> sys_nirq line
> >> > which is connected to T2 INTR1. This will fix the T2
> keypad wakeup
> >> > issue on OMAP3 SDP.
> >> >
> >> > Signed-off-by: Teerth Reddy < teerth@ti.com >
> >>
> >> Patch looks good, thanks. I'll pull this into PM branch and queue
> >> in my PM fixes queue for next merge window.
> >>
> >> I did a minor update by adding a comment in the
> >> enable_board_wakeup_source function stating that this is the
> >> interrupt pin used for T2.
> >>
> >> Kevin
> >>
> >
> > Teerth, Kevin,
> >
> > Did you test it with OFF mode enabled?
>
> I tested on SDP, but not on omap3evm since that was the only board
> file touched by this patch.
>
> > When I do "echo 1 > /sys/power/enable_off_mode" I don't see
> resume on the omap3evm.
> >
> > Schematics for the keypad are/seem to be same for EVM and SDP.
>
> I'm guessing that it's because the patch from Teerth only muxes this
> pin for the SDP. I'm guessing that doing the same omap_cfg_reg in the
> OMAP3EVM board file will get this working.
>
> Kevin
>
Kevin,
I have done the corresponding changes. See:
1) http://marc.info/?l=linux-omap&m=125725494430834&w=2
2) http://marc.info/?l=linux-omap&m=125725495630852&w=2
3) http://marc.info/?l=linux-omap&m=125725498430876&w=2
If I do suspend with OFF mode enabled (enable_off_mode=1), and
all power domains transition to target state, the key press
doesn't resume the system.
But, with this flag off OR any poer domain didn't transition to
the target state. The key press brings system out of 'suspend'.
Best regards,
Sanjeev
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
2009-11-04 14:01 ` Premi, Sanjeev
@ 2009-11-06 14:12 ` Premi, Sanjeev
0 siblings, 0 replies; 6+ messages in thread
From: Premi, Sanjeev @ 2009-11-06 14:12 UTC (permalink / raw)
To: Premi, Sanjeev, Kevin Hilman; +Cc: Reddy, Teerth, linux-omap@vger.kernel.org
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Premi, Sanjeev
> Sent: Wednesday, November 04, 2009 7:32 PM
> To: Kevin Hilman
> Cc: Reddy, Teerth; linux-omap@vger.kernel.org
> Subject: RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
[snip] --- [snip]
> > > Teerth, Kevin,
> > >
> > > Did you test it with OFF mode enabled?
> >
> > I tested on SDP, but not on omap3evm since that was the only board
> > file touched by this patch.
> >
> > > When I do "echo 1 > /sys/power/enable_off_mode" I don't see
> > resume on the omap3evm.
> > >
> > > Schematics for the keypad are/seem to be same for EVM and SDP.
> >
> > I'm guessing that it's because the patch from Teerth only muxes this
> > pin for the SDP. I'm guessing that doing the same
> omap_cfg_reg in the
> > OMAP3EVM board file will get this working.
> >
> > Kevin
> >
>
> Kevin,
>
> I have done the corresponding changes. See:
> 1) http://marc.info/?l=linux-omap&m=125725494430834&w=2
> 2) http://marc.info/?l=linux-omap&m=125725495630852&w=2
> 3) http://marc.info/?l=linux-omap&m=125725498430876&w=2
>
> If I do suspend with OFF mode enabled (enable_off_mode=1), and
> all power domains transition to target state, the key press
> doesn't resume the system.
>
> But, with this flag off OR any power domain didn't transition to
> the target state. The key press brings system out of 'suspend'.
>
Can someone with a 3430SDP or ZOOM board try this scenario?
I am trying to understand if it is a generic problem OR specific
to the omap3evm.
Best regards,
Sanjeev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-06 14:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-24 6:28 [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3 Reddy, Teerth
2009-08-27 8:25 ` Kevin Hilman
2009-11-03 16:32 ` Premi, Sanjeev
2009-11-03 22:04 ` Kevin Hilman
2009-11-04 14:01 ` Premi, Sanjeev
2009-11-06 14:12 ` Premi, Sanjeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox