From: Kevin Hilman <khilman@mvista.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: linux-omap@vger.kernel.org,
linux-omap-open-source <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH 3/3] ARM: OMAP: Add MUSB support for OMAP34xx
Date: Wed, 05 Dec 2007 11:43:23 -0800 [thread overview]
Message-ID: <87ve7d3p2c.fsf@vence.hilman.org> (raw)
In-Reply-To: <010C7BAE6783F34D9AC336EE5A01A08804F64BAA@dbde01.ent.ti.com> (Anand Gadiyar's message of "Wed\, 5 Dec 2007 18\:42\:05 +0530")
"Gadiyar, Anand" <gadiyar@ti.com> writes:
> This patch adds MUSB support for OMAP34XX.
[...]
> +static void musb_do_idle(unsigned long _musb)
> +{
> + struct musb *musb = (void *)_musb;
> + unsigned long flags;
> + u8 power;
> + u8 devctl;
> +
> + devctl = musb_readb(musb->mregs, MUSB_DEVCTL);
> +
> + spin_lock_irqsave(&musb->lock, flags);
This lock is never unlocked.
Might I recommend you turn on CONFIG_PREEMPT, and spinlock debugging
when testing. The various lock debugging features in the 'Kernel
Hacking' menu are extremely useful for this kind of thing.
Kevin
next prev parent reply other threads:[~2007-12-05 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 13:12 [PATCH 3/3] ARM: OMAP: Add MUSB support for OMAP34xx Gadiyar, Anand
2007-12-05 19:43 ` Kevin Hilman [this message]
2007-12-10 5:23 ` Gadiyar, Anand
[not found] <af454dfc0cc2c4362e679333aa3e7644@felipebalbi.com>
2007-12-11 9:43 ` Gadiyar, Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ve7d3p2c.fsf@vence.hilman.org \
--to=khilman@mvista.com \
--cc=gadiyar@ti.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox