linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Matt Porter <mporter@ti.com>, Chase Maupin <chase.maupin@ti.com>,
	Jason Kridner <jdk@ti.com>, Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpsw: Fix interrupt storm among other things
Date: Mon, 28 Jan 2013 22:14:36 +0100	[thread overview]
Message-ID: <87wquxdn7n.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1359378668-26536-1-git-send-email-panto@antoniou-consulting.com> (Pantelis Antoniou's message of "Mon, 28 Jan 2013 15:11:08 +0200")

>>>>> "Pantelis" == Pantelis Antoniou <panto@antoniou-consulting.com> writes:

'among other things' is not a very descriptive commit message.

 Pantelis> Fix interrupt storm on bone A4 cause by non-by-the-book
 Pantelis> interrupt handling.  While at it, added a non-NAPI mode
 Pantelis> (which is easier to debug), plus some general fixes.

'bone A4' is also not very descriptive. There also was an A4 revision of
the "old" beaglebone. I guess you're instead referring to a new die
revision?

What is the impact of this change on earlier devices?

 Pantelis> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
 Pantelis> @@ -20,6 +20,7 @@ Required properties:
 Pantelis>  - cpts_clock_shift	: Denominator to convert input clock ticks into nanoseconds
 Pantelis>  - phy_id		: Specifies slave phy id
 Pantelis>  - mac-address		: Specifies slave MAC address
 Pantelis> +- disable-napi		: Disables driver NAPI

napi is not a hardware feature, so it doesn't belong here (if anything,
it should be linux,disable-napi).

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-01-28 21:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 13:11 [PATCH] cpsw: Fix interrupt storm among other things Pantelis Antoniou
2013-01-28 18:24 ` Richard Cochran
2013-01-28 18:40   ` Pantelis Antoniou
2013-01-28 19:49     ` Richard Cochran
2013-01-28 19:56     ` Richard Cochran
2013-01-28 18:27 ` Richard Cochran
2013-01-28 21:14 ` Peter Korsgaard [this message]
2013-01-30  8:34   ` Pantelis Antoniou
2013-01-29 11:45 ` Mugunthan V N
2013-01-30  8:36   ` Pantelis Antoniou
2013-01-30  9:03     ` Mugunthan V N
2013-01-30  9:36       ` Pantelis Antoniou
2013-01-30 10:55         ` Mugunthan V N
2013-01-30 11:08           ` Pantelis Antoniou
2013-01-30 12:38             ` Bedia, Vaibhav
2013-01-30 12:44               ` Pantelis Antoniou
2013-01-30 13:29                 ` Bedia, Vaibhav
2013-01-30 13:37                   ` Pantelis Antoniou
2013-01-30 13:47                     ` Bedia, Vaibhav
2013-01-30 13:51                       ` Pantelis Antoniou
2013-01-30 13:53                         ` Mugunthan V N
2013-01-30 13:55                           ` Pantelis Antoniou
2013-01-30 14:03                             ` Mugunthan V N
2013-01-30 19:27                             ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wquxdn7n.fsf@dell.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=chase.maupin@ti.com \
    --cc=jdk@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=mugunthanvnm@ti.com \
    --cc=panto@antoniou-consulting.com \
    --cc=richardcochran@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).