From: Kevin Hilman <khilman@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
rnayak@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/7] OMAP2+: PM: Initialise sleep_switch to a non-valid value
Date: Fri, 08 Jul 2011 07:19:32 -0700 [thread overview]
Message-ID: <87wrfsc0sr.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1107071635230.2647@utopia.booyaka.com> (Paul Walmsley's message of "Thu, 7 Jul 2011 16:36:50 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> cc'ing Kevin, since this touches mach-omap2/pm.c - an ack would be great
> if you have the chance
>
> On Fri, 1 Jul 2011, Benoit Cousson wrote:
>
>> From: Rajendra Nayak <rnayak@ti.com>
>>
>> sleep_switch which is initialised to 0 in omap_set_pwrdm_state
>> happens to be a valid sleep_switch type (FORCEWAKEUP_SWITCH)
>> which are defined as:
>>
>> #define FORCEWAKEUP_SWITCH 0
>> #define LOWPOWERSTATE_SWITCH 1
>>
>> This causes the function to wrongly program some clock domains
>> even when the Powerdomain is in ON state.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>> Cc: Paul Walmsley <paul@pwsan.com>
Acked-by: Kevin Hilman <khilman@ti.com>
>
> Thanks, this patch has been queued for 3.1 at
> git://git.pwsan.com/linux-2.6 in the 'powerdomain_fixes_3.1' branch.
>
>
> - Paul
next prev parent reply other threads:[~2011-07-08 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 21:26 [PATCH v4 0/7] Fix module-mode enable sequence on OMAP4 Benoit Cousson
2011-07-01 21:27 ` [PATCH v4 1/7] OMAP2+: clockdomain: Add an api to read idle mode Benoit Cousson
2011-07-09 0:06 ` Paul Walmsley
2011-07-01 21:27 ` [PATCH v4 2/7] OMAP2+: clockdomain: Add SoC support for clkdm_allows_idle Benoit Cousson
2011-07-01 21:27 ` [PATCH v4 3/7] OMAP2+: PM: Initialise sleep_switch to a non-valid value Benoit Cousson
2011-07-07 22:36 ` Paul Walmsley
2011-07-08 14:19 ` Kevin Hilman [this message]
2011-07-01 21:27 ` [PATCH v4 4/7] OMAP2+: PM: idle clkdms only if already in idle Benoit Cousson
2011-07-07 22:37 ` Paul Walmsley
2011-07-08 14:19 ` Kevin Hilman
2011-07-01 21:27 ` [PATCH v4 5/7] OMAP2+: clockdomain: Add 2 APIs to control clockdomain from hwmod framework Benoit Cousson
2011-07-01 21:27 ` [PATCH v4 6/7] OMAP2+: clockdomain: Add per clkdm lock to prevent concurrent state programming Benoit Cousson
2011-07-01 21:27 ` [PATCH v4 7/7] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence Benoit Cousson
2011-07-09 8:15 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrfsc0sr.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox