From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] OMAP3: run the ASM sleep code from DDR Date: Wed, 29 Jun 2011 16:30:13 -0700 Message-ID: <87wrg4p662.fsf@ti.com> References: <1309365623-14704-1-git-send-email-j-pihet@ti.com> <87mxh0tuk2.fsf@ti.com> <20110629180535.GF23312@n2100.arm.linux.org.uk> <8762nosbj4.fsf@ti.com> <20110629215423.GI23312@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aob106.obsmtp.com ([74.125.149.76]:43748 "EHLO na3sys009aog106.obsmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752574Ab1F2XaR (ORCPT ); Wed, 29 Jun 2011 19:30:17 -0400 Received: by mail-iy0-f172.google.com with SMTP id 7so1526760iye.3 for ; Wed, 29 Jun 2011 16:30:17 -0700 (PDT) In-Reply-To: <20110629215423.GI23312@n2100.arm.linux.org.uk> (Russell King's message of "Wed, 29 Jun 2011 22:54:23 +0100") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: jean.pihet@newoldbits.com, linux-omap@vger.kernel.org, santosh.shilimkar@ti.com, linux-arm-kernel@lists.infradead.org, Jean Pihet Russell King - ARM Linux writes: > On Wed, Jun 29, 2011 at 12:06:07PM -0700, Kevin Hilman wrote: >> Russell King - ARM Linux writes: >> >> > On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: >> >> Russell, if you're OK with it, can you add it to your suspend branch for >> >> the upcoming merge window? >> > >> > Yes - though I think we can go a little bit further - this patch is on >> > top of my code so far, and is untested. There isn't a need for the >> > saving of these registers to be in assembly because we can read them >> > just as easily from C code. >> >> Indeed >> >> > Comments? >> >> Looks good to me (although untested) care to respin on top of $SUBJECT >> patch? >> >> Minor comments below... > > Done. Tested-by: Kevin Hilman Tested full-chip retention and off on 3430/n900, 3530/Overo and 3630/Zoom3. Kevin