From: Kevin Hilman <khilman@ti.com>
To: sricharan <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com,
tony@atomide.com, paul@pswan.com, gadiyar@ti.com,
b-cousson@ti.com
Subject: Re: [PATCH v2 3/5] omap3: board-3430sdp: Initialise the serial pads.
Date: Tue, 01 Feb 2011 17:13:03 -0800 [thread overview]
Message-ID: <87wrljme74.fsf@ti.com> (raw)
In-Reply-To: <1296483770-21915-1-git-send-email-r.sricharan@ti.com> (sricharan's message of "Mon, 31 Jan 2011 19:52:50 +0530")
sricharan <r.sricharan@ti.com> writes:
> Corrected a checkpatch warning.
This is not a changelog. This is a patch version history, which belongs
after the '---'
Kevin
> Signed-off-by: sricharan <r.sricharan@ti.com>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 86 ++++++++++++++++++++++++++++++++++-
> 1 files changed, 85 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 3b39ef1..896fcde 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -663,6 +663,90 @@ static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
> static struct omap_board_mux board_mux[] __initdata = {
> { .reg_offset = OMAP_MUX_TERMINATOR },
> };
> +
> +static struct omap_device_pad serial1_pads[] __initdata = {
> + { .name = "uart1_cts.uart1_cts",
> + .enable = OMAP_PIN_INPUT|
> + OMAP_PIN_OFF_INPUT_PULLDOWN |
> + OMAP_MUX_MODE0,
> + },
> + { .name = "uart1_rts.uart1_rts",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> + { .name = "uart1_rx.uart1_rx",
> + .enable = OMAP_PIN_INPUT | OMAP_PIN_OFF_INPUT_PULLDOWN |
> + OMAP_MUX_MODE0,
> + },
> + { .name = "uart1_tx.uart1_tx",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> +};
> +
> +static struct omap_device_pad serial2_pads[] __initdata = {
> + { .name = "uart2_cts.uart2_cts",
> + .enable = OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_INPUT_PULLDOWN |
> + OMAP_MUX_MODE0,
> + },
> + { .name = "uart2_rts.uart2_rts",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> + { .name = "uart2_rx.uart2_rx",
> + .enable = OMAP_PIN_INPUT | OMAP_PIN_OFF_INPUT_PULLDOWN |
> + OMAP_MUX_MODE0,
> + },
> + { .name = "uart2_tx.uart2_tx",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> +};
> +
> +static struct omap_device_pad serial3_pads[] __initdata = {
> + { .name = "uart3_cts_rctx.uart3_cts_rctx",
> + .enable = OMAP_PIN_INPUT_PULLDOWN |
> + OMAP_PIN_OFF_INPUT_PULLDOWN | OMAP_MUX_MODE0,
> + },
> + { .name = "uart3_rts_sd.uart3_rts_sd",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> + { .name = "uart3_rx_irrx.uart3_rx_irrx",
> + .enable = OMAP_PIN_INPUT | OMAP_PIN_OFF_INPUT_PULLDOWN |
> + OMAP_MUX_MODE0,
> + },
> + { .name = "uart3_tx_irtx.uart3_tx_irtx",
> + .enable = OMAP_PIN_OUTPUT | OMAP_MUX_MODE0,
> + },
> +};
> +
> +static struct omap_board_data serial1_data = {
> + .id = 0,
> + .pads = serial1_pads,
> + .pads_cnt = ARRAY_SIZE(serial1_pads),
> +};
> +
> +static struct omap_board_data serial2_data = {
> + .id = 1,
> + .pads = serial2_pads,
> + .pads_cnt = ARRAY_SIZE(serial2_pads),
> +};
> +
> +static struct omap_board_data serial3_data = {
> + .id = 2,
> + .pads = serial3_pads,
> + .pads_cnt = ARRAY_SIZE(serial3_pads),
> +};
> +
> +static inline void board_serial_init(void)
> +{
> + omap_serial_init_port(&serial1_data);
> + omap_serial_init_port(&serial2_data);
> + omap_serial_init_port(&serial3_data);
> +}
> +#else
> +#define board_mux NULL
> +
> +static inline void board_serial_init(void)
> +{
> + omap_serial_init();
> +}
> #endif
>
> /*
> @@ -804,7 +888,7 @@ static void __init omap_3430sdp_init(void)
> spi_register_board_info(sdp3430_spi_board_info,
> ARRAY_SIZE(sdp3430_spi_board_info));
> ads7846_dev_init();
> - omap_serial_init();
> + board_serial_init();
> usb_musb_init(&musb_board_data);
> board_smc91x_init();
> board_flash_init(sdp_flash_partitions, chip_sel_3430);
prev parent reply other threads:[~2011-02-02 1:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 14:22 [PATCH v2 3/5] omap3: board-3430sdp: Initialise the serial pads sricharan
2011-02-02 1:13 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrljme74.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pswan.com \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox