From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Abraham Arce <x0066660@ti.com>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
Syed Rafiuddin <rafiuddin.syed@ti.com>
Subject: Re: [PATCH v6 7/8] OMAP4: Keyboard board support
Date: Fri, 01 Oct 2010 16:05:47 -0700 [thread overview]
Message-ID: <87wrq14ipg.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101001225127.GE3117@atomide.com> (Tony Lindgren's message of "Fri, 1 Oct 2010 15:51:27 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Dmitry Torokhov <dmitry.torokhov@gmail.com> [100929 23:32]:
>> HI Abraham,
>>
>> On Thu, Sep 30, 2010 at 12:36:13AM -0500, Abraham Arce wrote:
>> > From: Syed Rafiuddin <rafiuddin.syed@ti.com>
>> >
>> > Keyboard support for SDP OMAP4430
>> >
>>
>> I think this would benefit from "const" sprinkled on it.
>>
>> BTW, I picked up patches 2, 3, 4, 5, 8 (all touching drivers/input).
>
> Thanks, I'll take 1, 6 & 7.
Dmitry,
Can you please drop patch 8 (the pm runtime one.) As pointed out by
Charu, with the proposed platform changes, this cannot work
correctly with runtime PM.
Tony, I also propose we don't merge the platform code yet either until
Abraham can respond to the platform-specific issues and runtime PM
issues.
I'm fine with Dmitry merging the rest of the driver changes though.
Kevin
next prev parent reply other threads:[~2010-10-01 23:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 5:36 [PATCH v6 7/8] OMAP4: Keyboard board support Abraham Arce
2010-09-30 6:40 ` Dmitry Torokhov
2010-09-30 7:04 ` Abraham Arce
2010-09-30 7:36 ` Dmitry Torokhov
2010-10-01 22:51 ` Tony Lindgren
2010-10-01 23:05 ` Kevin Hilman [this message]
2010-10-01 23:14 ` Tony Lindgren
2010-10-01 23:20 ` Abraham Arce
2010-10-01 23:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrq14ipg.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafiuddin.syed@ti.com \
--cc=tony@atomide.com \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox