From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [pm-wip-opp][PATCH] omap3: pm: fix opp initialization
Date: Wed, 06 Jan 2010 16:30:20 -0800 [thread overview]
Message-ID: <87wrzu7o4j.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1262817757-21937-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Wed\, 6 Jan 2010 16\:42\:37 -0600")
Nishanth Menon <nm@ti.com> writes:
> dsp_opp and l3_opps are reversed as part of commit 6e1276ff
> this is wrong as the correct order needs to be l3, dsp
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
Thanks.
I folded this into the original patch and pushed an updated
pm-wip-opp.
Kevin
> ---
> This was identified as part of investigation into Kevin's initial
> report here:
> http://marc.info/?l=linux-omap&m=126150035411486&w=2
>
> arch/arm/mach-omap2/pm34xx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 9744a35..7d12a3f 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -1361,8 +1361,8 @@ void __init omap3_pm_init_opp_table(void)
> };
> struct omap_opp **omap3_rate_tables[] = {
> &mpu_opps,
> - &dsp_opps,
> - &l3_opps
> + &l3_opps,
> + &dsp_opps
> };
>
> omap3_opp_def_list = cpu_is_omap3630() ? omap36xx_opp_def_list :
> --
> 1.6.3.3
prev parent reply other threads:[~2010-01-07 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 22:42 [pm-wip-opp][PATCH] omap3: pm: fix opp initialization Nishanth Menon
2010-01-07 0:30 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrzu7o4j.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox