From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] OMAP3: PM: Move the clk stabilization delay to the right place Date: Mon, 29 Jun 2009 16:16:36 -0700 Message-ID: <87ws6u636z.fsf@deeprootsystems.com> References: <1246015755-9267-1-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f190.google.com ([209.85.216.190]:50797 "EHLO mail-px0-f190.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbZF2XRT (ORCPT ); Mon, 29 Jun 2009 19:17:19 -0400 Received: by pxi28 with SMTP id 28so3684496pxi.33 for ; Mon, 29 Jun 2009 16:17:22 -0700 (PDT) In-Reply-To: <1246015755-9267-1-git-send-email-rnayak@ti.com> (Rajendra Nayak's message of "Fri\, 26 Jun 2009 16\:59\:15 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: linux-omap@vger.kernel.org Rajendra Nayak writes: > The clock stabilization delay post a M2 divider change is needed > even before a SDRC interface clock re-enable and not only before > jumping back to SDRAM. > > Signed-off-by: Rajendra Nayak Thanks, pushing to PM branch (and pm-2.6.29) Kevin > --- > arch/arm/mach-omap2/sram34xx.S | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/sram34xx.S b/arch/arm/mach-omap2/sram34xx.S > index f41f8d9..481f912 100644 > --- a/arch/arm/mach-omap2/sram34xx.S > +++ b/arch/arm/mach-omap2/sram34xx.S > @@ -97,6 +97,8 @@ ENTRY(omap3_sram_configure_core_dpll) > blne lock_dll > bl sdram_in_selfrefresh @ put SDRAM in self refresh, idle SDRC > bl configure_core_dpll @ change the DPLL3 M2 divider > + mov r12, r5 > + bl wait_clk_stable @ wait for SDRC to stabilize > bl enable_sdrc @ take SDRC out of idle > cmp r4, #SDRC_UNLOCK_DLL @ wait for DLL status to change > bleq wait_dll_unlock > @@ -104,8 +106,6 @@ ENTRY(omap3_sram_configure_core_dpll) > cmp r7, #1 @ if increasing SDRC clk rate, > beq return_to_sdram @ return to SDRAM code, otherwise, > bl configure_sdrc @ reprogram SDRC regs now > - mov r12, r5 > - bl wait_clk_stable @ wait for SDRC to stabilize > return_to_sdram: > isb @ prevent speculative exec past here > mov r0, #0 @ return value > -- > 1.5.4.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html