Re: [RFC] dt: export of_have_populated_dt

Cousson, Benoit
2012-04-10T16:20:08Z

Hi Balaji,

On 4/10/2012 5:11 PM, Balaji T K wrote:
> If of_have_populated_dt is called from module, build fails with "allnodes"
> undefined error, so remove inline and export of_have_populated_dt.

Is this function really called from the MMC driver?

Regards,
Benoit

>
> Signed-off-by: Balaji T K<balajitk@ti.com>
> ---
> drivers/of/base.c | 6 ++++++
> include/linux/of.h | 6 +-----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 5806449..dc1af42 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -186,6 +186,12 @@ struct property *of_find_property(const struct device_node *np,
> }
> EXPORT_SYMBOL(of_find_property);
>
> +bool of_have_populated_dt(void)
> +{
> + return allnodes != NULL;
> +}
> +EXPORT_SYMBOL(of_have_populated_dt);
> +
> /**
> * of_find_all_nodes - Get next node in global list
> * @prev: Previous node or NULL to start iteration
> diff --git a/include/linux/of.h b/include/linux/of.h
> index fa7fb1d..28e933e 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -92,11 +92,6 @@ extern struct device_node *of_chosen;
> extern struct device_node *of_aliases;
> extern rwlock_t devtree_lock;
>
> -static inline bool of_have_populated_dt(void)
> -{
> - return allnodes != NULL;
> -}
> -
> static inline bool of_node_is_root(const struct device_node *node)
> {
> return node&& (node->parent == NULL);
> @@ -112,6 +107,7 @@ static inline void of_node_set_flag(struct device_node *n, unsigned long flag)
> set_bit(flag,&n->_flags);
> }
>
> +extern bool of_have_populated_dt(void);
> extern struct device_node *of_find_all_nodes(struct device_node *prev);
>
> /*