From: Kevin Hilman <khilman@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: l-o <linux-omap@vger.kernel.org>,
l-a <linux-arm-kernel@lists.infradead.org>,
Tony <tony@atomide.com>, Koen Kooi <koen@beagleboard.org>
Subject: Re: [PATCH 1/2] omap3|4: opp: make omapx_opp_init non-static
Date: Tue, 01 Feb 2011 14:01:00 -0800 [thread overview]
Message-ID: <87y65zpg83.fsf@ti.com> (raw)
In-Reply-To: <1294260576-20237-2-git-send-email-nm@ti.com> (Nishanth Menon's message of "Wed, 5 Jan 2011 14:49:35 -0600")
Nishanth Menon <nm@ti.com> writes:
> omap3 and omap4 opp_init should be made non-static to allow
> for platform specific opp table tweaking. making these static
> conflicts with the definition in pm.h(global) as well.
> we include pm.h as well to ensure that there are no such prototype
> conflicts with actual implementation in the future.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Thanks, queuing for 2.6.39 (branch: for_2.6.39/pm-misc)
Kevin
> ---
> arch/arm/mach-omap2/opp3xxx_data.c | 3 ++-
> arch/arm/mach-omap2/opp4xxx_data.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach-omap2/opp3xxx_data.c
> index 0486fce..fd3a1af 100644
> --- a/arch/arm/mach-omap2/opp3xxx_data.c
> +++ b/arch/arm/mach-omap2/opp3xxx_data.c
> @@ -21,6 +21,7 @@
> #include <plat/cpu.h>
>
> #include "omap_opp_data.h"
> +#include "pm.h"
>
> static struct omap_opp_def __initdata omap34xx_opp_def_list[] = {
> /* MPU OPP1 */
> @@ -88,7 +89,7 @@ static struct omap_opp_def __initdata omap36xx_opp_def_list[] = {
> /**
> * omap3_opp_init() - initialize omap3 opp table
> */
> -static int __init omap3_opp_init(void)
> +int __init omap3_opp_init(void)
> {
> int r = -ENODEV;
>
> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
> index a11fa56..f0e9939 100644
> --- a/arch/arm/mach-omap2/opp4xxx_data.c
> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
> @@ -22,6 +22,7 @@
> #include <plat/cpu.h>
>
> #include "omap_opp_data.h"
> +#include "pm.h"
>
> static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
> /* MPU OPP1 - OPP50 */
> @@ -42,7 +43,7 @@ static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
> /**
> * omap4_opp_init() - initialize omap4 opp table
> */
> -static int __init omap4_opp_init(void)
> +int __init omap4_opp_init(void)
> {
> int r = -ENODEV;
next prev parent reply other threads:[~2011-02-01 22:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 20:49 [PATCH 0/2] OMAP3: Beagle: enable 800MHz for xm Nishanth Menon
2011-01-05 20:49 ` [PATCH 1/2] omap3|4: opp: make omapx_opp_init non-static Nishanth Menon
2011-02-01 22:01 ` Kevin Hilman [this message]
2011-01-05 20:49 ` [PATCH 2/2] OMAP3: beagle xm: enable upto 800MHz OPP Nishanth Menon
2011-01-05 23:28 ` Kevin Hilman
2011-01-06 12:24 ` Nishanth Menon
2011-01-06 13:00 ` Koen Kooi
2011-01-06 13:44 ` Nishanth Menon
2011-01-06 13:58 ` Premi, Sanjeev
2011-01-06 14:00 ` Nishanth Menon
2011-01-06 14:22 ` Premi, Sanjeev
2011-01-06 14:01 ` Koen Kooi
2011-01-06 14:07 ` Nishanth Menon
2011-01-07 13:04 ` Aaro Koskinen
2011-01-07 13:30 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y65zpg83.fsf@ti.com \
--to=khilman@ti.com \
--cc=koen@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox