linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found
@ 2010-04-23  5:41 Ambresh K
  2010-04-26 18:25 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Ambresh K @ 2010-04-23  5:41 UTC (permalink / raw)
  To: linux-omap; +Cc: Thara Gopinath, Kevin Hilman

Added clock domain name to sr[1,2] clk structure to fix warning
while initialising sr hwmod during boot-up.

Signed-off-by: Ambresh K <ambresh@ti.com>
---
 arch/arm/mach-omap2/clock3xxx_data.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
index d5153b6..8a49d8a 100644
--- a/arch/arm/mach-omap2/clock3xxx_data.c
+++ b/arch/arm/mach-omap2/clock3xxx_data.c
@@ -3100,6 +3100,7 @@ static struct clk sr1_fck = {
 	.parent		= &sys_ck,
 	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
 	.enable_bit	= OMAP3430_EN_SR1_SHIFT,
+	.clkdm_name	= "wkup_clkdm",
 	.recalc		= &followparent_recalc,
 };
 
@@ -3110,6 +3111,7 @@ static struct clk sr2_fck = {
 	.parent		= &sys_ck,
 	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
 	.enable_bit	= OMAP3430_EN_SR2_SHIFT,
+	.clkdm_name	= "wkup_clkdm",
 	.recalc		= &followparent_recalc,
 };
 
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found
  2010-04-23  5:41 [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found Ambresh K
@ 2010-04-26 18:25 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2010-04-26 18:25 UTC (permalink / raw)
  To: Ambresh K; +Cc: linux-omap, Thara Gopinath

Ambresh K <ambresh@ti.com> writes:

> Added clock domain name to sr[1,2] clk structure to fix warning
> while initialising sr hwmod during boot-up.
>
> Signed-off-by: Ambresh K <ambresh@ti.com>

Please add a better subject and changelog.  Something that would be
more useful when looking at this in git history down the road.
Something like "add SR clocks to WKUP clockdomain" for the suject is
more helpful.

Also, for the changelog, explain more about SmartReflex having its own
powerdomain but no clockdomain, thus why it's clocks are in the WKUP
clockdomain.

Kevin


> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
> index d5153b6..8a49d8a 100644
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> @@ -3100,6 +3100,7 @@ static struct clk sr1_fck = {
>  	.parent		= &sys_ck,
>  	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
>  	.enable_bit	= OMAP3430_EN_SR1_SHIFT,
> +	.clkdm_name	= "wkup_clkdm",
>  	.recalc		= &followparent_recalc,
>  };
>  
> @@ -3110,6 +3111,7 @@ static struct clk sr2_fck = {
>  	.parent		= &sys_ck,
>  	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
>  	.enable_bit	= OMAP3430_EN_SR2_SHIFT,
> +	.clkdm_name	= "wkup_clkdm",
>  	.recalc		= &followparent_recalc,
>  };
>  
> -- 
> 1.6.0.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-26 18:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-23  5:41 [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found Ambresh K
2010-04-26 18:25 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).