Re: [PATCH] Smartreflex: Avoid unnecessary spam

[Kevin Hilman <khilman@deeprootsystems.com>]

Tero Kristo <tero.kristo@nokia.com> writes:

> From: Tero Kristo <tero.kristo@nokia.com>
>
> Current warning messages will be constantly printed out during normal operation
> if smartreflex autocompensation is disabled.
>
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>

Agreed that these warnings are spam, but I think they should be
replaced by some one-time warning so at least there's a hint someplace
that SR is not actually being done on a platfrom.

Kevin

> ---
>  arch/arm/mach-omap2/smartreflex.c |   10 +---------
>  1 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index be3a1da..db228b2 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -675,13 +675,8 @@ void sr_start_vddautocomap(int srid, u32 target_opp_no)
>  		sr_configure(sr);
>  	}
>  
> -	if (sr->is_autocomp_active == 1)
> -		pr_warning("SR%d: VDD autocomp is already active\n",
> -									srid);
> -
>  	sr->is_autocomp_active = 1;
>  	if (!sr_enable(sr, target_opp_no)) {
> -		pr_warning("SR%d: VDD autocomp not activated\n", srid);
>  		sr->is_autocomp_active = 0;
>  		if (sr->is_sr_reset == 1)
>  			sr_clk_disable(sr);
> @@ -707,11 +702,8 @@ int sr_stop_vddautocomap(int srid)
>  		/* Reset the volatage for current OPP */
>  		sr_reset_voltage(srid);
>  		return true;
> -	} else {
> -		pr_warning("SR%d: VDD autocomp is not active\n",
> -								srid);
> +	} else
>  		return false;
> -	}
>  
>  }
>  EXPORT_SYMBOL(sr_stop_vddautocomap);
> -- 
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html