From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio
Date: Fri, 28 Aug 2009 10:19:15 +0300 [thread overview]
Message-ID: <87y6p41k3w.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1250878280-10667-1-git-send-email-vikram.pandita@ti.com> (Vikram Pandita's message of "Fri\, 21 Aug 2009 13\:11\:20 -0500")
Vikram Pandita <vikram.pandita@ti.com> writes:
> Release the Dbg board detection gpio once its purpose is served
>
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
Looks fine, I'll pull into my fixes queue.
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/board-zoom-debugboard.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
> index 4dd714d..d80e448 100644
> --- a/arch/arm/mach-omap2/board-zoom-debugboard.c
> +++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
> @@ -130,6 +130,7 @@ static inline void __init zoom2_init_quaduart(void)
> static inline int omap_zoom2_debugboard_detect(void)
> {
> int debug_board_detect = 0;
> + int ret = 1;
>
> debug_board_detect = ZOOM2_SMSC911X_GPIO;
>
> @@ -141,10 +142,10 @@ static inline int omap_zoom2_debugboard_detect(void)
> gpio_direction_input(debug_board_detect);
>
> if (!gpio_get_value(debug_board_detect)) {
> - gpio_free(debug_board_detect);
> - return 0;
> + ret = 0;
> }
> - return 1;
> + gpio_free(debug_board_detect);
> + return ret;
> }
>
> static struct platform_device *zoom2_devices[] __initdata = {
> --
> 1.6.3.3.334.g916e1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-08-28 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 18:11 [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio Vikram Pandita
2009-08-28 7:19 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6p41k3w.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox