[PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio

[PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio

[Vikram Pandita]

Release the Dbg board detection gpio once its purpose is served

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/mach-omap2/board-zoom-debugboard.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
index 4dd714d..d80e448 100644
--- a/arch/arm/mach-omap2/board-zoom-debugboard.c
+++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
@@ -130,6 +130,7 @@ static inline void __init zoom2_init_quaduart(void)
 static inline int omap_zoom2_debugboard_detect(void)
 {
 	int debug_board_detect = 0;
+	int ret = 1;
 
 	debug_board_detect = ZOOM2_SMSC911X_GPIO;
 
@@ -141,10 +142,10 @@ static inline int omap_zoom2_debugboard_detect(void)
 	gpio_direction_input(debug_board_detect);
 
 	if (!gpio_get_value(debug_board_detect)) {
-		gpio_free(debug_board_detect);
-		return 0;
+		ret = 0;
 	}
-	return 1;
+	gpio_free(debug_board_detect);
+	return ret;
 }
 
 static struct platform_device *zoom2_devices[] __initdata = {
-- 
1.6.3.3.334.g916e1

Re: [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio

[Kevin Hilman]

Vikram Pandita <vikram.pandita@ti.com> writes:

> Release the Dbg board detection gpio once its purpose is served
>
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>

Looks fine, I'll pull into my fixes queue.

Thanks,

Kevin

> ---
>  arch/arm/mach-omap2/board-zoom-debugboard.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
> index 4dd714d..d80e448 100644
> --- a/arch/arm/mach-omap2/board-zoom-debugboard.c
> +++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
> @@ -130,6 +130,7 @@ static inline void __init zoom2_init_quaduart(void)
>  static inline int omap_zoom2_debugboard_detect(void)
>  {
>  	int debug_board_detect = 0;
> +	int ret = 1;
>  
>  	debug_board_detect = ZOOM2_SMSC911X_GPIO;
>  
> @@ -141,10 +142,10 @@ static inline int omap_zoom2_debugboard_detect(void)
>  	gpio_direction_input(debug_board_detect);
>  
>  	if (!gpio_get_value(debug_board_detect)) {
> -		gpio_free(debug_board_detect);
> -		return 0;
> +		ret = 0;
>  	}
> -	return 1;
> +	gpio_free(debug_board_detect);
> +	return ret;
>  }
>  
>  static struct platform_device *zoom2_devices[] __initdata = {
> -- 
> 1.6.3.3.334.g916e1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html