* [PATCH v3] OMAP: timer-gp: Fix for null pointer dereferencing issue
@ 2009-07-16 12:21 Mittal, Mukund
2009-07-16 21:10 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Mittal, Mukund @ 2009-07-16 12:21 UTC (permalink / raw)
To: linux-omap@vger.kernel.org; +Cc: Kevin Hilman
From: Mukund Mittal <mmittal@ti.com>
OMAP: timer-gp: Fix for null pointer dereferencing issue
Calling WARN_ON() to warn for null pointer dereferencing for gpt pointer.
Signed-off-by: Mukund Mittal <mmittal@ti.com>
---
arch/arm/mach-omap2/timer-gp.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/mach-omap2/timer-gp.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/timer-gp.c
+++ linux-omap-2.6/arch/arm/mach-omap2/timer-gp.c
@@ -211,8 +211,10 @@ static void __init omap2_gp_clocksource_
"%s: can't register clocksource!\n";
gpt = omap_dm_timer_request();
- if (!gpt)
+ if (!gpt) {
printk(err1, clocksource_gpt.name);
+ WARN_ON(1);
+ }
gpt_clocksource = gpt;
omap_dm_timer_set_source(gpt, OMAP_TIMER_SRC_SYS_CLK);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3] OMAP: timer-gp: Fix for null pointer dereferencing issue
2009-07-16 12:21 [PATCH v3] OMAP: timer-gp: Fix for null pointer dereferencing issue Mittal, Mukund
@ 2009-07-16 21:10 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2009-07-16 21:10 UTC (permalink / raw)
To: Mittal, Mukund; +Cc: linux-omap@vger.kernel.org
"Mittal, Mukund" <mmittal@ti.com> writes:
> From: Mukund Mittal <mmittal@ti.com>
>
> OMAP: timer-gp: Fix for null pointer dereferencing issue
not exaclty a "fix". this patch will print a warning and
happily continue on and dereference the NULL.
> Calling WARN_ON() to warn for null pointer dereferencing for gpt pointer.
>
> Signed-off-by: Mukund Mittal <mmittal@ti.com>
> ---
> arch/arm/mach-omap2/timer-gp.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/mach-omap2/timer-gp.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/mach-omap2/timer-gp.c
> +++ linux-omap-2.6/arch/arm/mach-omap2/timer-gp.c
> @@ -211,8 +211,10 @@ static void __init omap2_gp_clocksource_
> "%s: can't register clocksource!\n";
>
> gpt = omap_dm_timer_request();
> - if (!gpt)
> + if (!gpt) {
> printk(err1, clocksource_gpt.name);
> + WARN_ON(1);
> + }
What you want is something like this (untested):
if (WARN_ON(!gpt1, err1, clocksource_gpt.name))
return;
> gpt_clocksource = gpt;
>
> omap_dm_timer_set_source(gpt, OMAP_TIMER_SRC_SYS_CLK);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-16 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-16 12:21 [PATCH v3] OMAP: timer-gp: Fix for null pointer dereferencing issue Mittal, Mukund
2009-07-16 21:10 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox