Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v2

[Kevin Hilman <khilman@deeprootsystems.com>]

Kim Kyuwon <chammoru@gmail.com> writes:

>>> +
>>> +void omap3_get_wakeup_status(struct pm_wakeup_status **pm_wkst)
>>> +{
>>> +     *pm_wkst = &omap3_pm_wkst;
>>> +}
>>> +
>>
>> Can you rename this to omap3_get_last_wake_state()
>
> Actually, I removed this function and I didn't get the WKST registers
> from the last PRCM interrupt in the new patch. Sorry that I don't
> address your suggestion. But I found that the PRCM interrupt is being
> generated in normal state on the latest PM branch and, from OMAP34XX
> TRM (4.9 PRCM Interrupts), PRCM Interrupts can be generated in many
> cases in addition to wake-up from suspend. So if my wakeup code gets
> the WSKT values from PRCM interrupt, I think it could show the wrong
> information.
>

What type of wrong information do you think you would get?

After looking again, you are probably querying the WKST registers
too late.  This version was not querying until someone dumped
the sysfs regs.  In that case, some other idle event could have
changed the WKST regs.

What you should do is query the WKST regs in your early_resume hook
(the same place you query the pending IRQs.)  This way you know
exactly when the WKST regs are taken.

Kevin