Re: [PATCH PM-0 v2] ARM: OMAP3: HSMMC: Ensure HSMMC is fully reset on boot

[Kevin Hilman <khilman@deeprootsystems.com>]

"Madhusudhan Chikkature" <madhu.cr@ti.com> writes:

>> This ensures that each HSMMC block is reset so it will not interfere
>> with retention or OFF-mode.
>> 
>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

[...]

> This might not be the right place to reset the controllers. You can
> avoid all the clk stuff if you do the reset in the driver probe
> function after the clocks are enabled.

The point is that this needs to be done even when the MMC driver is
NOT built into the kernel, or in the case of a module, before the MMC
driver is loaded.

> BTW, What is the issue you are facing if you dont reset the
> controllers? 

See mail from Jouni where he described it well.

> I have seen that on L-o that suspend/resume works with this driver
> enabled.

Without this patch, suspend/resume may work, but you may not hit
retention or OFF.  As Jouni also described, some boards work without
this patch, and others do not.

Kevin