From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: McSPI interfaces in newer kernel Date: Tue, 11 Dec 2007 11:59:43 -0800 Message-ID: <87y7c13suo.fsf@vence.hilman.org> References: <94d6903b0712111115h297769e2q1709777dd0e65bb7@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <94d6903b0712111115h297769e2q1709777dd0e65bb7@mail.gmail.com> (Meng Hu's message of "Tue\, 11 Dec 2007 13\:15\:21 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Meng Hu Cc: Linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org "Meng Hu" writes: > I am trying to jump from a 2.6.10 montavista kernel to a 2.6.21 one > for OMAP2430. > There are some patches from MonvaVista(originally provided by TI) for > the 2.6.10 kernel which provides some McSPI implementations, e.g. > drivers/ssi/omap-mcspi.c > > I found that these files are not in my 2.6.21 kernel and neither in > the upstream omap linux tree. For the MV 2.6.21-based kernel, we moved from using the TI SPI driver to the upstream driver (drivers/spi/omap2_mcspi.c) > Is this because the upstream kernel only contains a small set of omap > drivers OR these old mscpi drivers are replaced by sth. else? The "old" driver you're referring to was never upstream, it's only in the TI kernel (and re-used in the MV kernel.) For the MV 2.6.21-based kernel, since there was an upstream driver, we moved to the upstream driver. There are many drivers/features which are in the TI kernels which are not in the upstream kernels. Feel free to help us all remedy that. Patches are welcome. :) > Should I port these files by myself? or change my other drivers to use > the new interfaces. (I am porting a touchscreen driver which heavily > relies on the old mscpi drivers) I would recommend you use the new driver. If there is any functionality in the older driver that is not in the newer one, I recommend you report it here, preferably with a patch that adds it to the new driver. :) Kevin