From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod Date: Mon, 22 Oct 2012 14:46:17 -0700 Message-ID: <87zk3edvti.fsf@deeprootsystems.com> References: <1350922532-26338-1-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:45304 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755742Ab2JVVpv (ORCPT ); Mon, 22 Oct 2012 17:45:51 -0400 Received: by mail-pa0-f46.google.com with SMTP id hz1so2246388pad.19 for ; Mon, 22 Oct 2012 14:45:51 -0700 (PDT) In-Reply-To: <1350922532-26338-1-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Mon, 22 Oct 2012 19:15:32 +0300") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tero Kristo Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paul Walmsley , Benoit Cousson , Venkatraman S Tero Kristo writes: > When waking up from off-mode, some IP blocks are reset automatically by > hardware. For this reason, software must wait until the reset has > completed before attempting to access the IP block. > > This patch fixes for example the bug introduced by commit > 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c ("mmc: omap_hsmmc: remove access > to SYSCONFIG register"), in which the MMC IP block is reset during > off-mode entry, but the code expects the module to be already available > during the execution of context restore. > > Signed-off-by: Tero Kristo > Cc: Paul Walmsley > Cc: Benoit Cousson > Cc: Venkatraman S I can confirm that this patch the regression in my OMAP3 PM tests where suspend test (to retention or off) failed if ran after the off-idle test. Tested-by: Kevin Hilman on 3530/Overo, 3730/OveroSTORM, 3730/Beagle-xM Thanks Tero for the fix, Kevin