From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data Date: Mon, 14 May 2012 15:24:11 -0700 Message-ID: <87zk9apfjo.fsf@ti.com> References: <1336716163-2960-1-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:40989 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932521Ab2ENWYO (ORCPT ); Mon, 14 May 2012 18:24:14 -0400 Received: by pbbrq13 with SMTP id rq13so6824124pbb.8 for ; Mon, 14 May 2012 15:24:13 -0700 (PDT) In-Reply-To: <1336716163-2960-1-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Fri, 11 May 2012 11:32:43 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Vaibhav Hiremath Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Paul Walmsley , Santosh Shilimkar , R Sricharan Vaibhav Hiremath writes: > From: Kevin Hilman > > There are certain fields inside 'struct dpll_data' which are > included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it > difficult to use it for new devices like, am33xx, ti81xx, etc... > > So remove the ifdef completely, this will add few fields to the struct > unused, but it improves readability and maintainability of the code. > > Signed-off-by: Kevin Hilman > Signed-off-by: Vaibhav Hiremath > Cc: Tony Lindgren > Cc: Paul Walmsley > Cc: Santosh Shilimkar > Cc: R Sricharan > --- > Since Kevin had provided this idea and code change, > making this patch under his authorship. Be sure to give yourself credit for writing the changelog. Normally, if you make changes/additions to patch, you can add a line just before your signoff. Something like: [hvaibhav@ti.com: wrote detailed changelog] Kevin