* [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
@ 2012-05-11 6:02 Vaibhav Hiremath
2012-05-11 6:31 ` Shilimkar, Santosh
2012-05-14 22:24 ` Kevin Hilman
0 siblings, 2 replies; 6+ messages in thread
From: Vaibhav Hiremath @ 2012-05-11 6:02 UTC (permalink / raw)
To: linux-omap
Cc: linux-arm-kernel, Kevin Hilman, Vaibhav Hiremath, Tony Lindgren,
Paul Walmsley, Santosh Shilimkar, R Sricharan
From: Kevin Hilman <khilman@ti.com>
There are certain fields inside 'struct dpll_data' which are
included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
difficult to use it for new devices like, am33xx, ti81xx, etc...
So remove the ifdef completely, this will add few fields to the struct
unused, but it improves readability and maintainability of the code.
Signed-off-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: R Sricharan <r.sricharan@ti.com>
---
Since Kevin had provided this idea and code change,
making this patch under his authorship.
arch/arm/plat-omap/include/plat/clock.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/clock.h b/arch/arm/plat-omap/include/plat/clock.h
index d0ef57c..656b986 100644
--- a/arch/arm/plat-omap/include/plat/clock.h
+++ b/arch/arm/plat-omap/include/plat/clock.h
@@ -156,7 +156,6 @@ struct dpll_data {
u8 min_divider;
u16 max_divider;
u8 modes;
-#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
void __iomem *autoidle_reg;
void __iomem *idlest_reg;
u32 autoidle_mask;
@@ -167,7 +166,6 @@ struct dpll_data {
u8 auto_recal_bit;
u8 recal_en_bit;
u8 recal_st_bit;
-# endif
u8 flags;
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
2012-05-11 6:02 [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data Vaibhav Hiremath
@ 2012-05-11 6:31 ` Shilimkar, Santosh
2012-05-14 22:24 ` Kevin Hilman
1 sibling, 0 replies; 6+ messages in thread
From: Shilimkar, Santosh @ 2012-05-11 6:31 UTC (permalink / raw)
To: Vaibhav Hiremath
Cc: linux-omap, linux-arm-kernel, Kevin Hilman, Tony Lindgren,
Paul Walmsley, R Sricharan
On Fri, May 11, 2012 at 11:32 AM, Vaibhav Hiremath <hvaibhav@ti.com> wrote:
> From: Kevin Hilman <khilman@ti.com>
>
> There are certain fields inside 'struct dpll_data' which are
> included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> difficult to use it for new devices like, am33xx, ti81xx, etc...
>
> So remove the ifdef completely, this will add few fields to the struct
> unused, but it improves readability and maintainability of the code.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: R Sricharan <r.sricharan@ti.com>
> ---
Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
2012-05-11 6:02 [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data Vaibhav Hiremath
2012-05-11 6:31 ` Shilimkar, Santosh
@ 2012-05-14 22:24 ` Kevin Hilman
2012-05-15 5:41 ` Hiremath, Vaibhav
2012-06-14 15:01 ` Hiremath, Vaibhav
1 sibling, 2 replies; 6+ messages in thread
From: Kevin Hilman @ 2012-05-14 22:24 UTC (permalink / raw)
To: Vaibhav Hiremath
Cc: linux-omap, linux-arm-kernel, Tony Lindgren, Paul Walmsley,
Santosh Shilimkar, R Sricharan
Vaibhav Hiremath <hvaibhav@ti.com> writes:
> From: Kevin Hilman <khilman@ti.com>
>
> There are certain fields inside 'struct dpll_data' which are
> included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> difficult to use it for new devices like, am33xx, ti81xx, etc...
>
> So remove the ifdef completely, this will add few fields to the struct
> unused, but it improves readability and maintainability of the code.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: R Sricharan <r.sricharan@ti.com>
> ---
> Since Kevin had provided this idea and code change,
> making this patch under his authorship.
Be sure to give yourself credit for writing the changelog. Normally, if
you make changes/additions to patch, you can add a line just before your
signoff. Something like:
[hvaibhav@ti.com: wrote detailed changelog]
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
2012-05-14 22:24 ` Kevin Hilman
@ 2012-05-15 5:41 ` Hiremath, Vaibhav
2012-06-18 20:19 ` Paul Walmsley
2012-06-14 15:01 ` Hiremath, Vaibhav
1 sibling, 1 reply; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-05-15 5:41 UTC (permalink / raw)
To: Hilman, Kevin
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tony Lindgren, Paul Walmsley, Shilimkar, Santosh, R, Sricharan
On Tue, May 15, 2012 at 03:54:11, Hilman, Kevin wrote:
> Vaibhav Hiremath <hvaibhav@ti.com> writes:
>
> > From: Kevin Hilman <khilman@ti.com>
> >
> > There are certain fields inside 'struct dpll_data' which are
> > included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> > difficult to use it for new devices like, am33xx, ti81xx, etc...
> >
> > So remove the ifdef completely, this will add few fields to the struct
> > unused, but it improves readability and maintainability of the code.
> >
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: R Sricharan <r.sricharan@ti.com>
> > ---
> > Since Kevin had provided this idea and code change,
> > making this patch under his authorship.
>
> Be sure to give yourself credit for writing the changelog. Normally, if
> you make changes/additions to patch, you can add a line just before your
> signoff. Something like:
>
> [hvaibhav@ti.com: wrote detailed changelog]
>
Ok...
Paul,
Can you please add above statement, when you merge it into your repo?
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
2012-05-15 5:41 ` Hiremath, Vaibhav
@ 2012-06-18 20:19 ` Paul Walmsley
0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2012-06-18 20:19 UTC (permalink / raw)
To: Hiremath, Vaibhav
Cc: Hilman, Kevin, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Tony Lindgren,
Shilimkar, Santosh, R, Sricharan
On Tue, 15 May 2012, Hiremath, Vaibhav wrote:
> Paul,
> Can you please add above statement, when you merge it into your repo?
Added this, and added Santosh's ack, and queued for 3.6.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
2012-05-14 22:24 ` Kevin Hilman
2012-05-15 5:41 ` Hiremath, Vaibhav
@ 2012-06-14 15:01 ` Hiremath, Vaibhav
1 sibling, 0 replies; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-06-14 15:01 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Paul Walmsley, Shilimkar, Santosh, R, Sricharan, Hilman, Kevin
On Tue, May 15, 2012 at 03:54:11, Hilman, Kevin wrote:
> Vaibhav Hiremath <hvaibhav@ti.com> writes:
>
> > From: Kevin Hilman <khilman@ti.com>
> >
> > There are certain fields inside 'struct dpll_data' which are
> > included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> > difficult to use it for new devices like, am33xx, ti81xx, etc...
> >
> > So remove the ifdef completely, this will add few fields to the struct
> > unused, but it improves readability and maintainability of the code.
> >
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: R Sricharan <r.sricharan@ti.com>
> > ---
Tony,
Ping on this as well???
Thanks,
Vaibhav
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-18 20:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 6:02 [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data Vaibhav Hiremath
2012-05-11 6:31 ` Shilimkar, Santosh
2012-05-14 22:24 ` Kevin Hilman
2012-05-15 5:41 ` Hiremath, Vaibhav
2012-06-18 20:19 ` Paul Walmsley
2012-06-14 15:01 ` Hiremath, Vaibhav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).