From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver Date: Wed, 15 Jun 2011 08:37:26 -0700 Message-ID: <87zkljds21.fsf@ti.com> References: <1307713124-3946-1-git-send-email-carlos.chinea@nokia.com> <1307713124-3946-3-git-send-email-carlos.chinea@nokia.com> <874o3tmqhk.fsf@ti.com> <1308053544.2819.38115.camel@groo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1308053544.2819.38115.camel@groo> (Carlos Chinea's message of "Tue, 14 Jun 2011 15:12:24 +0300") Sender: linux-kernel-owner@vger.kernel.org To: Carlos Chinea Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org Carlos Chinea writes: > On Mon, 2011-06-13 at 13:21 -0700, ext Kevin Hilman wrote: >> Carlos Chinea writes: >> [...] >> > + * Copyright (C) 2010 Nokia Corporation. All rights reserved. >> > + * >> > + * Contact: Carlos Chinea >> > + * >> > + * This program is free software; you can redistribute it and/or >> > + * modify it under the terms of the GNU General Public License >> > + * version 2 as published by the Free Software Foundation. >> > + * >> > + * This program is distributed in the hope that it will be useful, but >> > + * WITHOUT ANY WARRANTY; without even the implied warranty of >> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> > + * General Public License for more details. >> > + * >> > + * You should have received a copy of the GNU General Public License >> > + * along with this program; if not, write to the Free Software >> > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA >> > + * 02110-1301 USA >> > + */ > -- cut -- > >> > +static struct platform_device ssi_pdev = { >> > + .name = "omap_ssi", >> > + .id = 0, >> > + .num_resources = ARRAY_SIZE(ssi_resources), >> > + .resource = ssi_resources, >> > + .dev = { >> > + .platform_data = &ssi_pdata, >> > + }, >> > +}; >> >> omap_hwmod has all the base address and IRQ data, will construct the >> struct resources and the platform_devices for you. Please use >> omap_hwmod + omap_device for this part of the code. >> > > Yes, it is already in my TODO list ;) > Great. Just so you know, we are not taking new OMAP drivers unless they are using omap_hwmod + omap_device to create the devices. Kevin