From: Kevin Hilman <khilman@ti.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Clock & PM breakage in 3.0-rc2
Date: Wed, 08 Jun 2011 11:32:47 -0700 [thread overview]
Message-ID: <87zklsi374.fsf@ti.com> (raw)
In-Reply-To: <20110608173143.0b03ebac.jhnikula@gmail.com> (Jarkko Nikula's message of "Wed, 8 Jun 2011 17:31:43 +0300")
Jarkko Nikula <jhnikula@gmail.com> writes:
> While debugging another issue I noticed that McBSP2 clock on Nokia N900
> doesn't get disabled in 3.0-rc2 after calling
> pm_runtime_put_sync(mcbsp->dev) and the fclk usecount remains active if
> the pm_runtime_get_sync(mcbsp->dev) was ever called activating it.
>
> I believe this affects other drivers too as the system is not able to
> enter into retention idle even if the mcbsp clocks are off.
>
> I traced breakage to commit 638080c ("OMAP2+ / PM: move runtime
> PM implementation to use device power domains").
>
> Reventing that and and 2064af9 ("PM: Revert "driver core: platform_bus:
> allow runtime override of dev_pm_ops") makes both mcbsp clocks and
> retention idle working again.
>
> Unfortunately I'm not able to see quickly what would be the right fix.
This should be fixed in my for_3.0/pm-fixes branch (pull req. sent to
Tony earlier this week.)
Specifically, the "OMAP: PM: omap_device: fix device power domain callbacks"
patch should fix your problem
Can you test again with merging that branch from:
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Kevin
next prev parent reply other threads:[~2011-06-08 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 14:31 Clock & PM breakage in 3.0-rc2 Jarkko Nikula
2011-06-08 18:32 ` Kevin Hilman [this message]
2011-06-09 6:10 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zklsi374.fsf@ti.com \
--to=khilman@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox