From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v4 0/6] OMAP: McSPI: Hwmod adaptation + runtime conversion Date: Mon, 24 Jan 2011 14:15:57 -0800 Message-ID: <87zkqq54o2.fsf@ti.com> References: <1295358759-11731-1-git-send-email-govindraj.raja@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog104.obsmtp.com ([74.125.149.73]:53177 "EHLO na3sys009aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107Ab1AXWQE (ORCPT ); Mon, 24 Jan 2011 17:16:04 -0500 Received: by mail-iy0-f180.google.com with SMTP id 21so4719113iyj.39 for ; Mon, 24 Jan 2011 14:16:00 -0800 (PST) In-Reply-To: <1295358759-11731-1-git-send-email-govindraj.raja@ti.com> (Govindraj R.'s message of "Tue, 18 Jan 2011 19:22:33 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Govindraj.R" Cc: linux-omap@vger.kernel.org, spi-devel-general@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca, charu@ti.com, b-cousson@ti.com, paul@pwsan.com, tony@atomide.com Hi Govindraj, "Govindraj.R" writes: > Changes invloves: > ---------------- > 1) Addition of hwmod data for omap2/3/4. > 2) McSPI driver hwmod adaptation with cleanup of base address > macros and using omap-device API's. > 3) Runtime Conversion of McSPI driver. Can you refresh this against current l-o master? It doesn't currently apply. I think this is probably ready to go into omap-testing for some broader exposure & testing. Thanks, Kevin > Changes fomr v3: > --------------- > 1) Updated proper Author for all patches which was missed > in v2. > 2) Modified 4430 hwmod data file so that mcspi data gets > updated in proper alphabetical order. > 3) Update omap2/3 hwmod dat files with SYSS_HAS_RESET_STATUS > flag. > > Changes from v2: > --------------- > 1) Fixing minor comments and adding ack from Grant Likely. > https://patchwork.kernel.org/patch/371321/ > https://patchwork.kernel.org/patch/371331/ > > Changes from v1: > --------------- > 1) Fixing patch 5/5 comments for hwmod+runtime > Split the patch 5/5 to hwmod adaptation > and then runtime conversion > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html > > Testing Updates: > ---------------- > Was tested using data transfer test module available at: > http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/ > utils/mcspi_modules/omap_mcspi_datatest.c; > h=e42ec10c5c844abdde6a7175a268b379fbbdb655; > hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3 > This test basically involves MISO <--> MOSI lines looped and data transfer test > done using the above test module. > System wide suspend and ret/off counts observation, ensured that no behavioral > difference with and without this patch series. > > Benoit Cousson (1): > OMAP4: hwmod data: Add McSPI > > Charulatha V (4): > OMAP2420: hwmod data: Add McSPI > OMAP2430: hwmod data: Add McSPI > OMAP3: hwmod data: Add McSPI > OMAP: devices: Modify McSPI device to adapt to hwmod framework > > Govindraj.R (1): > OMAP: runtime: McSPI driver runtime conversion > > arch/arm/mach-omap2/devices.c | 187 ++++--------------- > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 156 ++++++++++++++++ > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 219 ++++++++++++++++++++++ > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 280 ++++++++++++++++++++++++++++ > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 266 ++++++++++++++++++++++++++ > arch/arm/plat-omap/include/plat/mcspi.h | 11 + > drivers/spi/omap2_mcspi.c | 224 +++++++--------------- > 7 files changed, 1043 insertions(+), 300 deletions(-)