From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Varadarajan, Charulatha" <charu@ti.com>
Cc: tony@atomide.com, wim@iguana.be, linux-watchdog@vger.kernel.org,
paul@pwsan.com, b-cousson@ti.com, rnayak@ti.com, p-basak2@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [v4 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs
Date: Tue, 14 Sep 2010 11:04:47 -0700 [thread overview]
Message-ID: <87zkvknqv4.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1284390809-11519-7-git-send-email-charu@ti.com> (Charulatha Varadarajan's message of "Mon, 13 Sep 2010 20:43:29 +0530")
"Varadarajan, Charulatha" <charu@ti.com> writes:
> Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync()
> for enabling/disabling the clocks, sysconfig settings instead of using
> clock FW APIs.
>
> Signed-off-by: Charulatha V <charu@ti.com>
Looks mostly good, one minor comment
[...]
> +static int wdt_runtime_suspend(struct device *dev)
> +{
> + return 0;
> +}
> +
> +static int wdt_runtime_resume(struct device *dev)
> +{
> + return 0;
> +}
> +
> +static const struct dev_pm_ops gpio_pm_ops = {
> + .runtime_suspend = wdt_runtime_suspend,
> + .runtime_resume = wdt_runtime_resume,
> +};
> +
This isn't needed anymore for 2.6.37, a fix for the return values in the
generic runtime PM calls has been queued for 2.6.37[1]
Kevin
[1] https://lists.linux-foundation.org/pipermail/linux-pm/2010-September/028466.html
next prev parent reply other threads:[~2010-09-14 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 15:13 [v4 0/6] OMAP: WDT: Implement WDT in hwmod way Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 1/6] OMAP3: hwmod data: Add watchdog timer Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 2/6] OMAP2420: " Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 3/6] OMAP2430: " Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 4/6] OMAP4: " Varadarajan, Charulatha
2010-09-14 18:06 ` Kevin Hilman
2010-09-15 5:33 ` Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 5/6] OMAP2PLUS: WDT: use omap_device_build for device registration Varadarajan, Charulatha
2010-09-13 15:13 ` [v4 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs Varadarajan, Charulatha
2010-09-14 18:04 ` Kevin Hilman [this message]
2010-09-15 5:31 ` Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkvknqv4.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox