From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] DSPBRIDGE: use dm timer framework for gpt timers Date: Wed, 28 Apr 2010 10:59:32 -0700 Message-ID: <87zl0nfofv.fsf@deeprootsystems.com> References: <1272418167-12630-1-git-send-email-omar.ramirez@ti.com> <1272418167-12630-4-git-send-email-omar.ramirez@ti.com> <1272418167-12630-5-git-send-email-omar.ramirez@ti.com> <1272418167-12630-6-git-send-email-omar.ramirez@ti.com> <1272418167-12630-7-git-send-email-omar.ramirez@ti.com> <1272418167-12630-8-git-send-email-omar.ramirez@ti.com> <1272418167-12630-9-git-send-email-omar.ramirez@ti.com> <1272418167-12630-10-git-send-email-omar.ramirez@ti.com> <1272418167-12630-11-git-send-email-omar.ramirez@ti.com> <1272418167-12630-12-git-send-email-omar.ramirez@ti.com> <4BD8430B.80909@ti.com> <87bpd3h774.fsf@deeprootsystems.com> <4BD863FE.80804@ti.com> <4BD869A1.8070808@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:39590 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756185Ab0D1R7i (ORCPT ); Wed, 28 Apr 2010 13:59:38 -0400 Received: by pxi17 with SMTP id 17so2818525pxi.19 for ; Wed, 28 Apr 2010 10:59:37 -0700 (PDT) In-Reply-To: <4BD869A1.8070808@ti.com> (Omar Ramirez Luna's message of "Wed\, 28 Apr 2010 12\:00\:17 -0500") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Omar Ramirez Luna Cc: "Menon, Nishanth" , Felipe Contreras , linux-omap , Ameya Palande , Hiroshi Doyu , Felipe Contreras , Omar Ramirez Luna Omar Ramirez Luna writes: > On 4/28/2010 11:36 AM, Menon, Nishanth wrote: >> Kevin Hilman had written, on 04/28/2010 11:29 AM, the following: >>> Omar Ramirez Luna writes: >>> >>>> On 4/28/2010 2:46 AM, Felipe Contreras wrote: >>>>> On Wed, Apr 28, 2010 at 4:29 AM, Omar Ramirez Luna wrote: >>>>>> This patch switches to use DM timer framework instead of >>>>>> a custom one for GPT timers, currently dsp can make use of >>>>>> gpt 5, 6, 7 or 8. >>>>> I heard someone that was using gpt 8 for something else. Is it >>>>> possible to configure dsp-bridge to not use it? >>>>> >>>> There are two scenarios: >>>> >>>> 1. The request comes from the DSP side (afaik for video use case), the >>>> change should be in the DSP side binaries to request some other gpt >>>> instead. I don't know how possible is to get this changed. >>>> >>>> 2. bridge driver also requests gpt8 whenever a mmu fault is triggered, >>>> this to set a timer to interrupt the dsp after the mmu fault dump has >>>> been finished, I think this can be easily replaced in bridge to use >>>> some other gpt, but "1" is still there. (besides a new patch is needed >>>> to remove direct access to dm timer inside ue_deh and make it to go >>>> through dsp-clock) >>> >>> Why does Bridge care at all which specific timers it requests? They >>> are all the same, with the exception of GPT1 which is in the WKUP >>> powerdomain and already used as the kernel clocksource. >>> >>> Bridge should just use the generic _request() instead of >>> _request_specific() >>> >> trouble I believe is that DSP BIOS uses a specific timer. >> > > yes, dsp side wants: > bios --> GPT5 (only used during boot up -> baseimage load) > load monitoring --> GPT 6 (used while the dsp is awake) > AV Sync --> GPT 8 (based on use case) > > to generate the interrupt for mmu fault case it needs one connected to > the dsp interrupt line and only 5, 6, 7 or 8 apply. Then DSP bios is broken by hard-coding *general purpose* timers. Kevin