From: Kevin Hilman <khilman@deeprootsystems.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com,
vishwanath.bs@ti.com, sawant@ti.com
Subject: Re: [PATCHv3 20/22] OMAP3: PM: VP force update method of voltage scaling
Date: Tue, 27 Apr 2010 09:23:20 -0700 [thread overview]
Message-ID: <87zl0oq2yv.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1271408597-3066-21-git-send-email-thara@ti.com> (Thara Gopinath's message of "Fri\, 16 Apr 2010 14\:33\:15 +0530")
Thara Gopinath <thara@ti.com> writes:
> This patch introduces VP force update method of voltage scaling
> and enables it by default. The older method of vc bypass is now
> configuratble through a menu config option. VP force update is the
> hardware recommended method of voltage scaling.
>
> Signed-off-by: Thara Gopinath <thara@ti.com>
Hi Thara,
Could you (re) test this along with my changes to the PRCM IRQ handler:
https://patchwork.kernel.org/patch/95450/
I made a change (suggested by Mike Turquette) that affects how that
ISR clears PRCM interrupts. Previously, it would possibly interfere
with events you're polling for here, but it may never have seen.
[...]
> diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h
> index 8800369..473a953 100644
> --- a/arch/arm/mach-omap2/voltage.h
> +++ b/arch/arm/mach-omap2/voltage.h
> @@ -14,7 +14,10 @@
> #define VDD1 0
> #define VDD2 1
>
> +#define VOLTSCALE_VPFORCEUPDATE 1
> +#define VOLTSCALE_VCBYPASS 2
>
> +#define PRM_IRQSTATUS_REG_OFFSET OMAP3_PRM_IRQSTATUS_MPU_OFFSET
Don't use another #define, just use OMAP3_PRM_IRQSTATUS_MPU_OFFSET in
code directly Please.
Kevin
next prev parent reply other threads:[~2010-04-27 16:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 9:02 [PATCHv3 00/22] OMAP3: PM: Smartreflex and voltage revamp Thara Gopinath
2010-04-16 9:02 ` [PATCHv3 01/22] OMAP3: PM: Adding hwmod data for Smartreflex Thara Gopinath
2010-04-16 9:02 ` [PATCHv3 02/22] OMAP3: PM: Create list to keep track of various smartreflex instances Thara Gopinath
2010-04-16 9:02 ` [PATCHv3 03/22] OMAP3: PM: Convert smartreflex driver into a platform driver using hwmods and omap-device layer Thara Gopinath
2010-04-16 9:02 ` [PATCHv3 04/22] OMAP3: PM: Move smartreflex autocompensation enable disable hooks to PM debugfs Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 05/22] OMAP3: PM: Remove OPP id dependency from smartreflex driver Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 06/22] OMAP3: PM: Correcting API names in samrtreflex driver Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 07/22] OMAP3: PM: Smartreflex class related changes for smartreflex.c Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 08/22] OMAP3: PM: Adding smartreflex class 3 driver Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 09/22] OMAP3: PM: Creating separate files for handling OMAP3 voltage related operations Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 10/22] OMAP3: PM: Adding voltage table support in voltage driver Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 11/22] OMAP3: PM: Removing VP1, VP2, SR1 and SR2 defintions Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 12/22] OMAP3: PM: Minimizing the passing around of sr id in smartreflex.c Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 13/22] OMAP3: PM: Cleaning up of smartreflex header file Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 14/22] OMAP3: PM: Configurations for Smartreflex Class 2 and Smartreflex Class 3 Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 15/22] OMAP3: PM: Support for enabling smartreflex autocompensation by default Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 16/22] OMAP3: PM: Correcting accessing of ERRCONFIG register in smartreflex.c Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 17/22] OMAP3: PM: Implement latest h/w recommendations for SR and VP registers and SR VP enable disable sequence Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 18/22] OMAP3: PM: Optional reset of voltage during Smartreflex disable Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 19/22] OMAP3: PM: Disabling Smartreflex across both frequency and voltage scaling during DVFS Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 20/22] OMAP3: PM: VP force update method of voltage scaling Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 21/22] OMAP3: PM: Enabling Smartreflex Class 3 driver by default in pm defconfig Thara Gopinath
2010-04-16 9:03 ` [PATCHv3 22/22] OMAP3: PM: Fix crash when enabling SmartReflex on non-supported OMAPs Thara Gopinath
2010-04-27 16:23 ` Kevin Hilman [this message]
2010-04-27 19:16 ` [PATCHv3 20/22] OMAP3: PM: VP force update method of voltage scaling Kevin Hilman
2010-04-27 19:14 ` [PATCHv3 18/22] OMAP3: PM: Optional reset of voltage during Smartreflex disable Kevin Hilman
2010-05-05 11:03 ` Gopinath, Thara
2010-05-05 21:39 ` Kevin Hilman
2010-04-27 19:12 ` [PATCHv3 17/22] OMAP3: PM: Implement latest h/w recommendations for SR and VP registers and SR VP enable disable sequence Kevin Hilman
2010-04-27 19:10 ` [PATCHv3 15/22] OMAP3: PM: Support for enabling smartreflex autocompensation by default Kevin Hilman
2010-04-27 19:06 ` [PATCHv3 14/22] OMAP3: PM: Configurations for Smartreflex Class 2 and Smartreflex Class 3 Kevin Hilman
2010-04-27 19:02 ` [PATCHv3 12/22] OMAP3: PM: Minimizing the passing around of sr id in smartreflex.c Kevin Hilman
2010-05-13 7:13 ` Gopinath, Thara
2010-05-14 17:14 ` Kevin Hilman
2010-04-27 18:58 ` [PATCHv3 10/22] OMAP3: PM: Adding voltage table support in voltage driver Kevin Hilman
2010-04-27 18:43 ` [PATCHv3 05/22] OMAP3: PM: Remove OPP id dependency from smartreflex driver Kevin Hilman
2010-04-27 17:57 ` [PATCHv3 04/22] OMAP3: PM: Move smartreflex autocompensation enable disable hooks to PM debugfs Kevin Hilman
2010-04-27 17:47 ` [PATCHv3 03/22] OMAP3: PM: Convert smartreflex driver into a platform driver using hwmods and omap-device layer Kevin Hilman
2010-04-27 17:34 ` [PATCHv3 01/22] OMAP3: PM: Adding hwmod data for Smartreflex Kevin Hilman
2010-04-20 23:49 ` [PATCHv3 00/22] OMAP3: PM: Smartreflex and voltage revamp Kevin Hilman
2010-04-27 19:18 ` Kevin Hilman
2010-04-30 6:09 ` Gopinath, Thara
2010-04-30 14:22 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zl0oq2yv.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sawant@ti.com \
--cc=thara@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).