From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tero Kristo <tero.kristo@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] PM debug: Fix problems with PM timers
Date: Tue, 27 Jan 2009 07:15:57 -0800 [thread overview]
Message-ID: <87zlhcu6du.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1232959371-16669-1-git-send-email-tero.kristo@nokia.com> (Tero Kristo's message of "Mon\, 26 Jan 2009 10\:42\:51 +0200")
Tero Kristo <tero.kristo@nokia.com> writes:
> Camera sleep deny fix introduced a problem that broke MPU state timers, this
> is now fixed. Also removed DPLL* powerdomain timers from the status dumps.
>
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
Thanks, pushing to PM branch.
Kevin
> ---
> arch/arm/mach-omap2/pm-debug.c | 3 ++-
> arch/arm/mach-omap2/pm34xx.c | 3 +--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 2fc821a..bbd96a3 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -397,7 +397,8 @@ static int pwrdm_dbg_show_timer(struct powerdomain *pwrdm, void *user)
> int i;
>
> if (strcmp(pwrdm->name, "emu_pwrdm") == 0 ||
> - strcmp(pwrdm->name, "wkup_pwrdm") == 0)
> + strcmp(pwrdm->name, "wkup_pwrdm") == 0 ||
> + strncmp(pwrdm->name, "dpll", 4) == 0)
> return 0;
>
> pwrdm_state_switch(pwrdm);
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index b2db0ba..4ab37d5 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -407,8 +407,6 @@ void omap_sram_idle(void)
> OMAP3_PRM_VOLTCTRL_OFFSET);
> }
>
> - omap2_clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);
> -
> /* PER */
> if (per_next_state < PWRDM_POWER_ON) {
> per_prev_state = pwrdm_read_prev_pwrst(per_pwrdm);
> @@ -431,6 +429,7 @@ void omap_sram_idle(void)
>
> pwrdm_post_transition();
>
> + omap2_clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);
> }
>
> /*
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-01-27 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 8:42 [PATCH] PM debug: Fix problems with PM timers Tero Kristo
2009-01-27 15:15 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zlhcu6du.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=tero.kristo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox